From f36174e0722d82ea5473c17c3d901e30899fcb7b Mon Sep 17 00:00:00 2001 From: Stefan Hanreich Date: Mon, 10 Mar 2025 09:51:01 +0100 Subject: [PATCH] partial fix #5496: ipam: netbox: properly return allocated ip The netbox integration did not properly return the IP when creating the entries in netbox. This lead to errors on starting the guest, stating that an IP could not be allocated. Originally-by: lou lecrivain Signed-off-by: Stefan Hanreich Tested-by: Hannes Duerr Link: https://lore.proxmox.com/20250310085103.30549-6-s.hanreich@proxmox.com Signed-off-by: Thomas Lamprecht --- src/PVE/Network/SDN/Ipams/NetboxPlugin.pm | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/PVE/Network/SDN/Ipams/NetboxPlugin.pm b/src/PVE/Network/SDN/Ipams/NetboxPlugin.pm index 8051b3f..2fa975f 100644 --- a/src/PVE/Network/SDN/Ipams/NetboxPlugin.pm +++ b/src/PVE/Network/SDN/Ipams/NetboxPlugin.pm @@ -172,7 +172,7 @@ sub add_next_freeip { my $description = undef; $description = "mac:$mac" if $mac; - eval { + my $ip = eval { my $result = netbox_api_request($plugin_config, "POST", "/ipam/prefixes/$internalid/available-ips/", { dns_name => $hostname, description => $description, @@ -185,6 +185,8 @@ sub add_next_freeip { if ($@) { die "can't find free ip in subnet $cidr: $@" if !$noerr; } + + return $ip; } sub add_range_next_freeip { @@ -201,7 +203,7 @@ sub add_range_next_freeip { my $description = undef; $description = "mac:$data->{mac}" if $data->{mac}; - eval { + my $ip = eval { my $result = netbox_api_request($plugin_config, "POST", "/ipam/ip-ranges/$internalid/available-ips/", { dns_name => $data->{hostname}, description => $description, @@ -215,6 +217,8 @@ sub add_range_next_freeip { if ($@) { die "can't find free ip in range $range->{'start-address'}-$range->{'end-address'}: $@" if !$noerr; } + + return $ip; } sub del_ip { -- 2.39.5