From f13530f23a9ba73027f8f40b78eb81396afaa092 Mon Sep 17 00:00:00 2001 From: Sai Gomathi N Date: Thu, 27 Oct 2022 01:52:31 -0700 Subject: [PATCH] pimd: Unchecked return value In tib_sg_oil_setup: Value returned from a function is not checked for errors before being used. If the function returns an error value, the error value may be mistaken for a normal value. Here, only the nexthop value is being used. So casted the return type to void. Coverity CID-1519816 Signed-off-by: Sai Gomathi N --- pimd/pim_tib.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pimd/pim_tib.c b/pimd/pim_tib.c index 8f5de3e938..3455e30064 100644 --- a/pimd/pim_tib.c +++ b/pimd/pim_tib.c @@ -49,7 +49,8 @@ tib_sg_oil_setup(struct pim_instance *pim, pim_sgaddr sg, struct interface *oif) if (up) { memcpy(&nexthop, &up->rpf.source_nexthop, sizeof(struct pim_nexthop)); - pim_ecmp_nexthop_lookup(pim, &nexthop, vif_source, &grp, 0); + (void)pim_ecmp_nexthop_lookup(pim, &nexthop, vif_source, &grp, + 0); if (nexthop.interface) input_iface_vif_index = pim_if_find_vifindex_by_ifindex( pim, nexthop.interface->ifindex); -- 2.39.5