From eb649b7ff38df75fb2b5fc20a552b9a6d1f78063 Mon Sep 17 00:00:00 2001 From: Donald Sharp Date: Mon, 3 Apr 2017 18:28:26 -0400 Subject: [PATCH] lib, zebra: Fix CR comments lib -> Add a bit of documentation about what units we are in. zebra -> Fix failure case to be a bit better. Signed-off-by: Donald Sharp --- lib/if.h | 2 +- zebra/if_netlink.c | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/lib/if.h b/lib/if.h index d7ec495636..e8e84ffc88 100644 --- a/lib/if.h +++ b/lib/if.h @@ -229,7 +229,7 @@ struct interface /* Interface metric */ uint32_t metric; - /* Interface Speed */ + /* Interface Speed in Mb/s */ uint32_t speed; /* Interface MTU. */ diff --git a/zebra/if_netlink.c b/zebra/if_netlink.c index b1d4dd81d9..28538fabdf 100644 --- a/zebra/if_netlink.c +++ b/zebra/if_netlink.c @@ -330,8 +330,10 @@ get_iflink_speed (const char *ifname) /* Get the current link state for the interface */ rc = ioctl(sd, SIOCETHTOOL, (char *)&ifdata); if(rc < 0) { - zlog_debug ("IOCTL failure to read interface %s speed: %d %s", - ifname, errno, safe_strerror(errno)); + zlog_debug("IOCTL failure to read interface %s speed: %d %s", + ifname, errno, safe_strerror(errno)); + ecmd.speed_hi = 0; + ecmd.speed = 0; } close(sd); -- 2.39.5