From e531bbe2f06e01e5f890e9a62ae25b093407e4c3 Mon Sep 17 00:00:00 2001 From: Christian Franke Date: Tue, 14 Jun 2016 20:07:04 +0200 Subject: [PATCH] ospf6d: fix off-by-one on display of spf reasons The loop should only iterate to array_size - 1. Signed-off-by: Christian Franke Signed-off-by: Christian Franke Acked-by: Donald Sharp --- ospf6d/ospf6_spf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ospf6d/ospf6_spf.c b/ospf6d/ospf6_spf.c index 957988b53d..7e977499cf 100644 --- a/ospf6d/ospf6_spf.c +++ b/ospf6d/ospf6_spf.c @@ -444,7 +444,7 @@ void ospf6_spf_reason_string (unsigned int reason, char *buf, int size) if (!buf) return; - for (bit = 0; bit <= (sizeof(ospf6_spf_reason_str) / sizeof(char *)); bit++) + for (bit = 0; bit < array_size(ospf6_spf_reason_str); bit++) { if ((reason & (1 << bit)) && (len < size)) { -- 2.39.5