From e36e5b569c24ba0f28549b78677b9806da9965d3 Mon Sep 17 00:00:00 2001 From: "F. Aragon" Date: Fri, 29 Jun 2018 17:01:29 +0200 Subject: [PATCH] isisd zebra: dead code (Clang scan) This correction fixes two bugs detected by Clang scan: Bug Group: Dead store Bug Type: Dead assignment File: zebra/kernel_netlink.c Function: netlink_parse_extended_ack Line: 548 Bug Type: Dead increment File: isisd/isis_lsp.c Function: lsp_bits2string Line: 625 Signed-off-by: F. Aragon --- isisd/isis_lsp.c | 2 +- zebra/kernel_netlink.c | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/isisd/isis_lsp.c b/isisd/isis_lsp.c index bba86d4c1f..67e6bac8d7 100644 --- a/isisd/isis_lsp.c +++ b/isisd/isis_lsp.c @@ -622,7 +622,7 @@ static const char *lsp_bits2string(uint8_t lsp_bits, char *buf, size_t buf_size) pos += sprintf(pos, "%d/", ISIS_MASK_LSP_PARTITION_BIT(lsp_bits) ? 1 : 0); - pos += sprintf(pos, "%d", ISIS_MASK_LSP_OL_BIT(lsp_bits) ? 1 : 0); + sprintf(pos, "%d", ISIS_MASK_LSP_OL_BIT(lsp_bits) ? 1 : 0); return buf; } diff --git a/zebra/kernel_netlink.c b/zebra/kernel_netlink.c index 7334c8094a..d9c6631845 100644 --- a/zebra/kernel_netlink.c +++ b/zebra/kernel_netlink.c @@ -545,7 +545,6 @@ static void netlink_parse_extended_ack(struct nlmsghdr *h) if (off > h->nlmsg_len) { zlog_err("Invalid offset for NLMSGERR_ATTR_OFFS\n"); - off = 0; } else if (!(h->nlmsg_flags & NLM_F_CAPPED)) { /* * Header of failed message -- 2.39.5