From e1333d12e0d3ba8a9a0ca914dc72d0908dea494e Mon Sep 17 00:00:00 2001 From: Louis Scalbert Date: Thu, 28 Sep 2023 17:38:13 +0200 Subject: [PATCH] bgpd: fix printing link state ospf opaque data Fix printing link state ospf opaque data. pnt address was not moving in the loop. Fixes: 8b531b1107 ("bgpd: store and send bgp link-state attributes") Signed-off-by: Louis Scalbert --- bgpd/bgp_linkstate_tlv.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/bgpd/bgp_linkstate_tlv.c b/bgpd/bgp_linkstate_tlv.c index f2bd36524d..3669d68b85 100644 --- a/bgpd/bgp_linkstate_tlv.c +++ b/bgpd/bgp_linkstate_tlv.c @@ -1354,7 +1354,6 @@ static void bgp_linkstate_tlv_opaque_display(struct vty *vty, uint8_t *pnt, uint8_t *lim = pnt + length; bool ospf_tlv_header; char tlv_type[6]; - int i; if (json) { @@ -1400,21 +1399,15 @@ static void bgp_linkstate_tlv_opaque_display(struct vty *vty, uint8_t *pnt, continue; } - vty_out(vty, "\n%*sTLV type %u: 0x", indent, "", sub_type); + vty_out(vty, "\n%*sTLV type %u: ", indent, "", sub_type); if (pnt + sub_length > lim) { vty_out(vty, "Bad length received: %u\n", sub_length); break; } - for (i = 0; i < sub_length; i++) { - if (i != 0 && i % 8 == 0) - vty_out(vty, " "); - vty_out(vty, "%02x", *pnt); - } + bgp_linkstate_tlv_hexa_display(vty, pnt, sub_length, NULL); } - if (!json) - vty_out(vty, "\n"); } static void bgp_linkstate_tlv_rtm_capability_display(struct vty *vty, -- 2.39.5