From dade8dfdd69add9a051723ea26547cfcddb4ac14 Mon Sep 17 00:00:00 2001 From: Donald Sharp Date: Sun, 10 Sep 2023 09:17:20 -0400 Subject: [PATCH] bgpd: bgp_evpn_mh_route_delete should ensure dest is still usable Again coverity believes that dest may be freed but it should not be because of how locking is done. Make coverity happy. Signed-off-by: Donald Sharp --- bgpd/bgp_evpn_mh.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/bgpd/bgp_evpn_mh.c b/bgpd/bgp_evpn_mh.c index 91db9a061a..7700281cd2 100644 --- a/bgpd/bgp_evpn_mh.c +++ b/bgpd/bgp_evpn_mh.c @@ -513,8 +513,11 @@ static int bgp_evpn_mh_route_delete(struct bgp *bgp, struct bgp_evpn_es *es, */ delete_evpn_route_entry(bgp, afi, safi, dest, &pi); if (pi) - bgp_path_info_reap(dest, pi); + dest = bgp_path_info_reap(dest, pi); + + assert(dest); bgp_dest_unlock_node(dest); + return 0; } -- 2.39.5