From d94023d85c1682ae14def9d50f2474e8e6290e44 Mon Sep 17 00:00:00 2001 From: paco Date: Mon, 25 Jun 2018 15:25:26 +0200 Subject: [PATCH] pimd: untrusted argument (2) (Coverity 1465491) Additional fix over 18e994a0437cfba9f4c09bd62293e13e49ea774b (PR #2457) Previous correction was not enough for fixing the Coverity warning. Now we ensure we don't overflow the buffer. Signed-off-by: F. Aragon --- pimd/mtracebis.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pimd/mtracebis.c b/pimd/mtracebis.c index c63a6eeca9..a0e8fd1270 100644 --- a/pimd/mtracebis.c +++ b/pimd/mtracebis.c @@ -303,6 +303,9 @@ static int recv_response(int fd, int *hops, struct igmp_mtrace *mtracer) if (mtrace_len < (int)MTRACE_HDR_SIZE) return -1; + if (mtrace_len > (int)MTRACE_BUF_LEN) + return -1; + sum = mtrace->checksum; mtrace->checksum = 0; if (sum != in_cksum(mtrace, mtrace_len)) { -- 2.39.5