From d1ba1814bc17c4c029e85552048e64eca78f5ce8 Mon Sep 17 00:00:00 2001 From: Donald Sharp Date: Wed, 18 Mar 2020 07:15:05 -0400 Subject: [PATCH] lib: Ensure pointer exists before using in mlag Ensure that the s pointer is valid and usable before grabbing data off of it. Signed-off-by: Donald Sharp --- lib/mlag.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/mlag.c b/lib/mlag.c index 733dd41ea8..653fbe8fe9 100644 --- a/lib/mlag.c +++ b/lib/mlag.c @@ -85,9 +85,12 @@ int mlag_lib_decode_mlag_hdr(struct stream *s, struct mlag_msg *msg, size_t *length) { #define LIB_MLAG_HDR_LENGTH 8 + if (s == NULL || msg == NULL) + return -1; + *length = stream_get_endp(s); - if (s == NULL || msg == NULL || *length < LIB_MLAG_HDR_LENGTH) + if (*length < LIB_MLAG_HDR_LENGTH) return -1; *length -= LIB_MLAG_HDR_LENGTH; -- 2.39.5