From b7c657d4e065f310fcf6454abae1a963c208c3b8 Mon Sep 17 00:00:00 2001 From: Donatas Abraitis Date: Tue, 25 Mar 2025 17:20:56 +0200 Subject: [PATCH] bgpd: Retain the routes if we do a clear with N-bit set for Graceful-Restart On receiving side we already did the job correctly, but the peer which initiates the clear does not retain the other's routes. This commit fixes that. Fixes: 20170775da3a3c5d41aba714d0c1d5a29b0da61c ("bgpd: Activate Graceful-Restart when receiving CEASE/HOLDTIME notifications") Signed-off-by: Donatas Abraitis --- bgpd/bgp_packet.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/bgpd/bgp_packet.c b/bgpd/bgp_packet.c index 3d33a02db0..4c2eb03f3a 100644 --- a/bgpd/bgp_packet.c +++ b/bgpd/bgp_packet.c @@ -1038,6 +1038,13 @@ static void bgp_notify_send_internal(struct peer_connection *connection, /* Add packet to peer's output queue */ stream_fifo_push(connection->obuf, s); + /* If Graceful-Restart N-bit (Notification) is exchanged, + * and it's not a Hard Reset, let's retain the routes. + */ + if (bgp_has_graceful_restart_notification(peer) && !hard_reset && + CHECK_FLAG(peer->sflags, PEER_STATUS_NSF_MODE)) + SET_FLAG(peer->sflags, PEER_STATUS_NSF_WAIT); + bgp_peer_gr_flags_update(peer); BGP_GR_ROUTER_DETECT_AND_SEND_CAPABILITY_TO_ZEBRA(peer->bgp, peer->bgp->peer); -- 2.39.5