From a880bfaab28e837a54de5bd88dad1a755aa2e985 Mon Sep 17 00:00:00 2001 From: Donatas Abraitis Date: Sun, 13 Oct 2024 19:54:08 +0300 Subject: [PATCH] isisd: Remove circuit state check for openfabric If we have something like: ``` int eth1 ip router openfabric x ipv6 router openfabric x ``` And eth1 is removed, the first `ip router ...` fails and only `ipv6 router ...` is enabled. If we leave only: ``` int eth1 ipv6 router openfabric x ``` Then also, no interface is going to be enabled, which is weird too. Fixes: https://github.com/FRRouting/frr/issues/17075 Signed-off-by: Donatas Abraitis --- isisd/isis_vty_fabricd.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/isisd/isis_vty_fabricd.c b/isisd/isis_vty_fabricd.c index 0d25f66109..85ef2c40a1 100644 --- a/isisd/isis_vty_fabricd.c +++ b/isisd/isis_vty_fabricd.c @@ -218,17 +218,9 @@ DEFUN (ip_router_isis, if (!area) isis_area_create(area_tag, VRF_DEFAULT_NAME); - if (!circuit) { + if (!circuit) circuit = isis_circuit_new(ifp, area_tag); - if (circuit->state != C_STATE_CONF - && circuit->state != C_STATE_UP) { - vty_out(vty, - "Couldn't bring up interface, please check log.\n"); - return CMD_WARNING_CONFIG_FAILED; - } - } - bool ip = circuit->ip_router, ipv6 = circuit->ipv6_router; if (af[2] != '\0') ipv6 = true; -- 2.39.5