From a3116965bb2332901c5645ef119087dbd148a95f Mon Sep 17 00:00:00 2001 From: Donald Sharp Date: Tue, 24 Sep 2019 08:24:10 -0400 Subject: [PATCH] bgpd: rmap_type is 8 bit but we have 9 bits of flags The newly added PEER_RMAP_TYPE_AGGREGATE flag is setup to be the 9th bit: But the flag we are putting it into: uint8_t rmap_type; is 8 bits. Adjust the size. Found by Coverity SA Scan Signed-off-by: Donald Sharp --- bgpd/bgpd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bgpd/bgpd.h b/bgpd/bgpd.h index 9d45d96987..320f1ec96c 100644 --- a/bgpd/bgpd.h +++ b/bgpd/bgpd.h @@ -1202,7 +1202,7 @@ struct peer { uint8_t last_reset_cause[BGP_MAX_PACKET_SIZE]; /* The kind of route-map Flags.*/ - uint8_t rmap_type; + uint16_t rmap_type; #define PEER_RMAP_TYPE_IN (1 << 0) /* neighbor route-map in */ #define PEER_RMAP_TYPE_OUT (1 << 1) /* neighbor route-map out */ #define PEER_RMAP_TYPE_NETWORK (1 << 2) /* network route-map */ -- 2.39.5