From a2979a566b12414be05d65ce21d71a18a95bb331 Mon Sep 17 00:00:00 2001 From: Donald Sharp Date: Wed, 7 Jul 2021 16:00:12 -0400 Subject: [PATCH] lib: Allow ZAPI_MESSAGE_OPAQUE_LENGTH length of data We are sending up to ZAPI_MESSAGE_OPAQUE_LENGTH but checking for one less. We know the data will fit in it to that size. Also we have asserts on the write to ensure we don't go over it Fixes: #8995 Signed-off-by: Donald Sharp (cherry picked from commit 3b1849be3211bdc7c53bdeb0d982863dfe0284d0) --- lib/zclient.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/zclient.c b/lib/zclient.c index 365635a8da..bf4966a5d7 100644 --- a/lib/zclient.c +++ b/lib/zclient.c @@ -1418,7 +1418,7 @@ int zapi_route_decode(struct stream *s, struct zapi_route *api) if (CHECK_FLAG(api->message, ZAPI_MESSAGE_OPAQUE)) { STREAM_GETW(s, api->opaque.length); - assert(api->opaque.length < ZAPI_MESSAGE_OPAQUE_LENGTH); + assert(api->opaque.length <= ZAPI_MESSAGE_OPAQUE_LENGTH); STREAM_GET(api->opaque.data, s, api->opaque.length); } -- 2.39.5