From 9a5c3b931e0c4cf6f8bf7f9b2e31a04ea96250af Mon Sep 17 00:00:00 2001
From: Donatas Abraitis <donatas@opensourcerouting.org>
Date: Wed, 14 Aug 2024 20:15:08 +0300
Subject: [PATCH] Revert "tests: ipv6 global removal in bgp_nexthop_mp_ipv4_6"

This reverts commit 04c220bedb63334a65677a46ef84938cc812221f.
---
 .../r1/bgp_ipv6_step2.json                    | 90 -------------------
 .../r2/bgp_ipv6_step2.json                    | 48 ----------
 .../r3/bgp_ipv6_step2.json                    | 48 ----------
 .../r4/bgp_ipv6_step2.json                    | 49 ----------
 .../r5/bgp_ipv6_step2.json                    | 49 ----------
 .../r6/bgp_ipv6_step2.json                    | 48 ----------
 .../r7/bgp_ipv6_step2.json                    | 48 ----------
 .../r8/bgp_ipv6_step2.json                    | 48 ----------
 .../rr1/bgp_ipv6_step2.json                   | 62 -------------
 .../test_nexthop_mp_ipv4_6.py                 | 52 -----------
 10 files changed, 542 deletions(-)
 delete mode 100755 tests/topotests/bgp_nexthop_mp_ipv4_6/r1/bgp_ipv6_step2.json
 delete mode 100644 tests/topotests/bgp_nexthop_mp_ipv4_6/r2/bgp_ipv6_step2.json
 delete mode 100644 tests/topotests/bgp_nexthop_mp_ipv4_6/r3/bgp_ipv6_step2.json
 delete mode 100755 tests/topotests/bgp_nexthop_mp_ipv4_6/r4/bgp_ipv6_step2.json
 delete mode 100755 tests/topotests/bgp_nexthop_mp_ipv4_6/r5/bgp_ipv6_step2.json
 delete mode 100644 tests/topotests/bgp_nexthop_mp_ipv4_6/r6/bgp_ipv6_step2.json
 delete mode 100644 tests/topotests/bgp_nexthop_mp_ipv4_6/r7/bgp_ipv6_step2.json
 delete mode 100644 tests/topotests/bgp_nexthop_mp_ipv4_6/r8/bgp_ipv6_step2.json
 delete mode 100644 tests/topotests/bgp_nexthop_mp_ipv4_6/rr1/bgp_ipv6_step2.json

diff --git a/tests/topotests/bgp_nexthop_mp_ipv4_6/r1/bgp_ipv6_step2.json b/tests/topotests/bgp_nexthop_mp_ipv4_6/r1/bgp_ipv6_step2.json
deleted file mode 100755
index f7c5c7c3b5..0000000000
--- a/tests/topotests/bgp_nexthop_mp_ipv4_6/r1/bgp_ipv6_step2.json
+++ /dev/null
@@ -1,90 +0,0 @@
-{
-  "routes": {
-    "fd00:100::/64": [
-      {
-        "valid": true,
-        "bestpath": true,
-        "path": "",
-        "nexthops": [
-          {
-            "ip": "::",
-            "afi": "ipv6",
-            "used": true
-          }
-        ]
-      }
-    ],
-    "fd00:700::/64": [
-      {
-        "valid": true,
-        "multipath": true,
-        "path": "65000 65700",
-        "nexthops": [
-          {
-            "ip": "fd00:0:2::3",
-            "afi": "ipv6",
-            "scope": "global"
-          },
-          {
-            "afi": "ipv6",
-            "scope": "link-local",
-            "used": true
-          }
-        ]
-      },
-      {
-        "valid": true,
-        "bestpath": true,
-        "path": "65000 65700",
-        "nexthops": [
-          {
-            "ip": "fd00:0:1::2",
-            "afi": "ipv6",
-            "scope": "global"
-          },
-          {
-            "afi": "ipv6",
-            "scope": "link-local",
-            "used": true
-          }
-        ]
-      }
-    ],
-    "fd00:800::/64": [
-      {
-        "valid": true,
-        "multipath": true,
-        "path": "65000 65800",
-        "nexthops": [
-          {
-            "ip": "fd00:0:2::3",
-            "afi": "ipv6",
-            "scope": "global"
-          },
-          {
-            "afi": "ipv6",
-            "scope": "link-local",
-            "used": true
-          }
-        ]
-      },
-      {
-        "valid": true,
-        "bestpath": true,
-        "path": "65000 65800",
-        "nexthops": [
-          {
-            "ip": "fd00:0:1::2",
-            "afi": "ipv6",
-            "scope": "global"
-          },
-          {
-            "afi": "ipv6",
-            "scope": "link-local",
-            "used": true
-          }
-        ]
-      }
-    ]
-  }
-}
diff --git a/tests/topotests/bgp_nexthop_mp_ipv4_6/r2/bgp_ipv6_step2.json b/tests/topotests/bgp_nexthop_mp_ipv4_6/r2/bgp_ipv6_step2.json
deleted file mode 100644
index 21f36089b6..0000000000
--- a/tests/topotests/bgp_nexthop_mp_ipv4_6/r2/bgp_ipv6_step2.json
+++ /dev/null
@@ -1,48 +0,0 @@
-{
-  "routes": {
-    "fd00:100::/64": [
-      {
-        "valid": true,
-        "bestpath": true,
-        "path": "65100",
-        "nexthops": [
-          {
-            "afi": "ipv6",
-            "scope": "link-local",
-            "used": true
-          }
-        ]
-      }
-    ],
-    "fd00:700::/64": [
-      {
-        "valid": true,
-        "bestpath": true,
-        "path": "65700",
-        "nexthops": [
-          {
-            "ip": "fd00:0:9::7",
-            "scope": "global",
-            "afi": "ipv6",
-            "used": true
-          }
-        ]
-      }
-    ],
-    "fd00:800::/64": [
-      {
-        "valid": true,
-        "bestpath": true,
-        "path": "65800",
-        "nexthops": [
-          {
-            "ip": "fd00:0:9::8",
-            "scope": "global",
-            "afi": "ipv6",
-            "used": true
-          }
-        ]
-      }
-    ]
-  }
-}
diff --git a/tests/topotests/bgp_nexthop_mp_ipv4_6/r3/bgp_ipv6_step2.json b/tests/topotests/bgp_nexthop_mp_ipv4_6/r3/bgp_ipv6_step2.json
deleted file mode 100644
index 21f36089b6..0000000000
--- a/tests/topotests/bgp_nexthop_mp_ipv4_6/r3/bgp_ipv6_step2.json
+++ /dev/null
@@ -1,48 +0,0 @@
-{
-  "routes": {
-    "fd00:100::/64": [
-      {
-        "valid": true,
-        "bestpath": true,
-        "path": "65100",
-        "nexthops": [
-          {
-            "afi": "ipv6",
-            "scope": "link-local",
-            "used": true
-          }
-        ]
-      }
-    ],
-    "fd00:700::/64": [
-      {
-        "valid": true,
-        "bestpath": true,
-        "path": "65700",
-        "nexthops": [
-          {
-            "ip": "fd00:0:9::7",
-            "scope": "global",
-            "afi": "ipv6",
-            "used": true
-          }
-        ]
-      }
-    ],
-    "fd00:800::/64": [
-      {
-        "valid": true,
-        "bestpath": true,
-        "path": "65800",
-        "nexthops": [
-          {
-            "ip": "fd00:0:9::8",
-            "scope": "global",
-            "afi": "ipv6",
-            "used": true
-          }
-        ]
-      }
-    ]
-  }
-}
diff --git a/tests/topotests/bgp_nexthop_mp_ipv4_6/r4/bgp_ipv6_step2.json b/tests/topotests/bgp_nexthop_mp_ipv4_6/r4/bgp_ipv6_step2.json
deleted file mode 100755
index 7d0786c0ef..0000000000
--- a/tests/topotests/bgp_nexthop_mp_ipv4_6/r4/bgp_ipv6_step2.json
+++ /dev/null
@@ -1,49 +0,0 @@
-{
-  "routes": {
-    "fd00:100::/64": [
-      {
-        "valid": true,
-        "bestpath": true,
-        "path": "65100",
-        "nexthops": [
-          {
-            "ip": "2001:db8::2",
-            "afi": "ipv6",
-            "scope": "global",
-            "used": true
-          }
-        ]
-      }
-    ],
-    "fd00:700::/64": [
-      {
-        "valid": true,
-        "bestpath": true,
-        "path": "65700",
-        "nexthops": [
-          {
-            "ip": "fd00:0:9::7",
-            "scope": "global",
-            "afi": "ipv6",
-            "used": true
-          }
-        ]
-      }
-    ],
-    "fd00:800::/64": [
-      {
-        "valid": true,
-        "bestpath": true,
-        "path": "65800",
-        "nexthops": [
-          {
-            "ip": "fd00:0:9::8",
-            "scope": "global",
-            "afi": "ipv6",
-            "used": true
-          }
-        ]
-      }
-    ]
-  }
-}
diff --git a/tests/topotests/bgp_nexthop_mp_ipv4_6/r5/bgp_ipv6_step2.json b/tests/topotests/bgp_nexthop_mp_ipv4_6/r5/bgp_ipv6_step2.json
deleted file mode 100755
index 7d0786c0ef..0000000000
--- a/tests/topotests/bgp_nexthop_mp_ipv4_6/r5/bgp_ipv6_step2.json
+++ /dev/null
@@ -1,49 +0,0 @@
-{
-  "routes": {
-    "fd00:100::/64": [
-      {
-        "valid": true,
-        "bestpath": true,
-        "path": "65100",
-        "nexthops": [
-          {
-            "ip": "2001:db8::2",
-            "afi": "ipv6",
-            "scope": "global",
-            "used": true
-          }
-        ]
-      }
-    ],
-    "fd00:700::/64": [
-      {
-        "valid": true,
-        "bestpath": true,
-        "path": "65700",
-        "nexthops": [
-          {
-            "ip": "fd00:0:9::7",
-            "scope": "global",
-            "afi": "ipv6",
-            "used": true
-          }
-        ]
-      }
-    ],
-    "fd00:800::/64": [
-      {
-        "valid": true,
-        "bestpath": true,
-        "path": "65800",
-        "nexthops": [
-          {
-            "ip": "fd00:0:9::8",
-            "scope": "global",
-            "afi": "ipv6",
-            "used": true
-          }
-        ]
-      }
-    ]
-  }
-}
diff --git a/tests/topotests/bgp_nexthop_mp_ipv4_6/r6/bgp_ipv6_step2.json b/tests/topotests/bgp_nexthop_mp_ipv4_6/r6/bgp_ipv6_step2.json
deleted file mode 100644
index 55912dd74c..0000000000
--- a/tests/topotests/bgp_nexthop_mp_ipv4_6/r6/bgp_ipv6_step2.json
+++ /dev/null
@@ -1,48 +0,0 @@
-{
-  "routes": {
-    "fd00:100::/64": [
-      {
-        "valid": true,
-        "bestpath": true,
-        "nexthops": [
-          {
-            "ip": "2001:db8::2",
-            "afi": "ipv6",
-            "scope": "global",
-            "used": true
-          }
-        ]
-      }
-    ],
-    "fd00:700::/64": [
-      {
-        "valid": true,
-        "bestpath": true,
-        "path": "65700",
-        "nexthops": [
-          {
-            "ip": "fd00:0:9::7",
-            "afi": "ipv6",
-            "scope": "global",
-            "used": true
-          }
-        ]
-      }
-    ],
-    "fd00:800::/64": [
-      {
-        "valid": true,
-        "bestpath": true,
-        "path": "65800",
-        "nexthops": [
-          {
-            "ip": "fd00:0:9::8",
-            "afi": "ipv6",
-            "scope": "global",
-            "used": true
-          }
-        ]
-      }
-    ]
-  }
-}
diff --git a/tests/topotests/bgp_nexthop_mp_ipv4_6/r7/bgp_ipv6_step2.json b/tests/topotests/bgp_nexthop_mp_ipv4_6/r7/bgp_ipv6_step2.json
deleted file mode 100644
index 8fe5f7c1de..0000000000
--- a/tests/topotests/bgp_nexthop_mp_ipv4_6/r7/bgp_ipv6_step2.json
+++ /dev/null
@@ -1,48 +0,0 @@
-{
-  "routes": {
-    "fd00:100::/64": [
-      {
-        "valid": true,
-        "bestpath": true,
-        "path": "65000 65100",
-        "nexthops": [
-          {
-            "ip": "fd00:0:9::6",
-            "afi": "ipv6",
-            "scope": "global",
-            "used": true
-          }
-        ]
-      }
-    ],
-    "fd00:700::/64": [
-      {
-        "valid": true,
-        "bestpath": true,
-        "path": "",
-        "nexthops": [
-          {
-            "ip": "::",
-            "afi": "ipv6",
-            "used": true
-          }
-        ]
-      }
-    ],
-    "fd00:800::/64": [
-      {
-        "valid": true,
-        "bestpath": true,
-        "path": "65800",
-        "nexthops": [
-          {
-            "ip": "fd00:0:9::8",
-            "afi": "ipv6",
-            "scope": "global",
-            "used": true
-          }
-        ]
-      }
-    ]
-  }
-}
diff --git a/tests/topotests/bgp_nexthop_mp_ipv4_6/r8/bgp_ipv6_step2.json b/tests/topotests/bgp_nexthop_mp_ipv4_6/r8/bgp_ipv6_step2.json
deleted file mode 100644
index 20f4940328..0000000000
--- a/tests/topotests/bgp_nexthop_mp_ipv4_6/r8/bgp_ipv6_step2.json
+++ /dev/null
@@ -1,48 +0,0 @@
-{
-  "routes": {
-    "fd00:100::/64": [
-      {
-        "valid": true,
-        "bestpath": true,
-        "path": "65000 65100",
-        "nexthops": [
-          {
-            "ip": "fd00:0:9::6",
-            "afi": "ipv6",
-            "scope": "global",
-            "used": true
-          }
-        ]
-      }
-    ],
-    "fd00:700::/64": [
-      {
-        "valid": true,
-        "bestpath": true,
-        "path": "65700",
-        "nexthops": [
-          {
-            "ip": "fd00:0:9::7",
-            "afi": "ipv6",
-            "scope": "global",
-            "used": true
-          }
-        ]
-      }
-    ],
-    "fd00:800::/64": [
-      {
-        "valid": true,
-        "bestpath": true,
-        "path": "",
-        "nexthops": [
-          {
-            "ip": "::",
-            "afi": "ipv6",
-            "used": true
-          }
-        ]
-      }
-    ]
-  }
-}
diff --git a/tests/topotests/bgp_nexthop_mp_ipv4_6/rr1/bgp_ipv6_step2.json b/tests/topotests/bgp_nexthop_mp_ipv4_6/rr1/bgp_ipv6_step2.json
deleted file mode 100644
index 4ab0e1c2ae..0000000000
--- a/tests/topotests/bgp_nexthop_mp_ipv4_6/rr1/bgp_ipv6_step2.json
+++ /dev/null
@@ -1,62 +0,0 @@
-{
-  "routes": {
-    "fd00:100::/64": [
-      {
-        "valid": true,
-        "bestpath": true,
-        "path": "65100",
-        "nexthops": [
-          {
-            "ip": "2001:db8::2",
-            "afi": "ipv6",
-            "scope": "global",
-            "used": true
-          }
-        ]
-      },
-      {
-        "valid": true,
-        "multipath": true,
-        "path": "65100",
-        "nexthops": [
-          {
-            "ip": "2001:db8::3",
-            "afi": "ipv6",
-            "scope": "global",
-            "used": true
-          }
-        ]
-      }
-    ],
-    "fd00:700::/64": [
-      {
-        "valid": true,
-        "bestpath": true,
-        "path": "65700",
-        "nexthops": [
-          {
-            "ip": "fd00:0:9::7",
-            "afi": "ipv6",
-            "scope": "global",
-            "used": true
-          }
-        ]
-      }
-    ],
-    "fd00:800::/64": [
-      {
-        "valid": true,
-        "bestpath": true,
-        "path": "65800",
-        "nexthops": [
-          {
-            "ip": "fd00:0:9::8",
-            "afi": "ipv6",
-            "scope": "global",
-            "used": true
-          }
-        ]
-      }
-    ]
-  }
-}
diff --git a/tests/topotests/bgp_nexthop_mp_ipv4_6/test_nexthop_mp_ipv4_6.py b/tests/topotests/bgp_nexthop_mp_ipv4_6/test_nexthop_mp_ipv4_6.py
index 911a6d757f..4da13b16d1 100644
--- a/tests/topotests/bgp_nexthop_mp_ipv4_6/test_nexthop_mp_ipv4_6.py
+++ b/tests/topotests/bgp_nexthop_mp_ipv4_6/test_nexthop_mp_ipv4_6.py
@@ -226,58 +226,6 @@ def test_bgp_ping_ok_step1():
     check_ping("h1", "fd00:800::1", True, 5, 1)
 
 
-def test_bgp_ipv6_nexthop_step2():
-    """
-    Remove IPv6 global on r1 and r7
-    Assert that BGP has correct ipv6 nexthops.
-    """
-
-    tgen = get_topogen()
-    if tgen.routers_have_failure():
-        pytest.skip(tgen.errors)
-
-    tgen.gears["r1"].vtysh_cmd(
-        """
-configure
-interface eth-r2
- no ipv6 address fd00:0:1::1/64
-!
-interface eth-r3
- no ipv6 address fd00:0:2::1/64
-"""
-    )
-
-    for rname, router in tgen.routers().items():
-        if "h" in rname:
-            # hosts
-            continue
-        if "rs1" in rname:
-            continue
-        ref_file = "{}/{}/bgp_ipv6_step2.json".format(CWD, rname)
-        expected = json.loads(open(ref_file).read())
-        test_func = partial(
-            topotest.router_json_cmp,
-            router,
-            "show bgp ipv6 unicast json",
-            expected,
-        )
-        _, res = topotest.run_and_expect(test_func, None, count=30, wait=1)
-        assertmsg = "{}: BGP IPv6 Nexthop failure".format(rname)
-        assert res is None, assertmsg
-
-
-def test_bgp_ping_ok_step2():
-    "Check that h1 pings h2 and h3"
-    tgen = get_topogen()
-    if tgen.routers_have_failure():
-        pytest.skip(tgen.errors)
-
-    check_ping("h1", "192.168.7.1", True, 5, 1)
-    check_ping("h1", "fd00:700::1", True, 5, 1)
-    check_ping("h1", "192.168.8.1", True, 5, 1)
-    check_ping("h1", "fd00:800::1", True, 5, 1)
-
-
 if __name__ == "__main__":
     args = ["-s"] + sys.argv[1:]
     sys.exit(pytest.main(args))
-- 
2.39.5