From 9a38a7b055252427c10124517c3e8990a82d78da Mon Sep 17 00:00:00 2001 From: Eugene Bogomazov Date: Wed, 22 Jun 2022 15:09:06 +0300 Subject: [PATCH] bgpd: simplify ebgp role check for RFC 9234 BGP Role is currently defined only for eBGP session. So, we don't need to consider which roles can be applied on iBGP session and thus simplify code fragment. Signed-off-by: Eugene Bogomazov --- bgpd/bgpd.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/bgpd/bgpd.c b/bgpd/bgpd.c index 7cfe5654ac..91843160ed 100644 --- a/bgpd/bgpd.c +++ b/bgpd/bgpd.c @@ -4934,10 +4934,7 @@ int peer_role_set(struct peer *peer, uint8_t role, bool strict_mode) bgp_session_reset(peer); } } else { - if (peer->sort == BGP_PEER_IBGP && - (role == ROLE_CUSTOMER || role == ROLE_PROVIDER || - role == ROLE_PEER || role == ROLE_RS_SERVER || - role == ROLE_RS_CLIENT)) + if (peer->sort != BGP_PEER_EBGP) return BGP_ERR_INVALID_INTERNAL_ROLE; peer->local_role = role; if (strict_mode) -- 2.39.5