From 873b1431d671295809a073eb93e85d4e9e7789b3 Mon Sep 17 00:00:00 2001 From: Stefan Hanreich Date: Wed, 9 Apr 2025 00:15:12 +0200 Subject: [PATCH] frr: remove erroneous outfunc from frr-reload command Prior to the upgrade to frr-pythontools 10.2.1, frr-reload.py did not print any output to STDOUT, which masked the erroneous outfunc provided in run_command. With 10.2.1 frr-reload.py now prints to STDOUT, which triggers the codepath for invoking the outfunc, leading to an error when invoking frr-reload.py. By removing the outfunc the invocation works again. In addition to fixing the regression introduced, we also now print the frr-reload.py informational output to the tasklog, which can be helpful in debugging any issues when reloading the frr configuration. Signed-off-by: Stefan Hanreich --- src/PVE/Network/SDN/Controllers/EvpnPlugin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/Network/SDN/Controllers/EvpnPlugin.pm b/src/PVE/Network/SDN/Controllers/EvpnPlugin.pm index c245ea2..535c1e6 100644 --- a/src/PVE/Network/SDN/Controllers/EvpnPlugin.pm +++ b/src/PVE/Network/SDN/Controllers/EvpnPlugin.pm @@ -634,7 +634,7 @@ sub reload_controller { if (-e $conf_file && -e $bin_path) { eval { - run_command([$bin_path, '--stdout', '--reload', $conf_file], outfunc => {}, errfunc => $err); + run_command([$bin_path, '--stdout', '--reload', $conf_file], errfunc => $err); }; if ($@) { warn "frr reload command fail. Restarting frr."; -- 2.39.5