From 850de337d922ecbb8f55098ecd067e63df0fecd9 Mon Sep 17 00:00:00 2001
From: Lou Berger <lberger@labn.net>
Date: Sat, 27 Jan 2018 17:00:58 -0500
Subject: [PATCH] lib: ltemplate simplify start/stop

Signed-off-by: Lou Berger <lberger@labn.net>
---
 tests/topotests/lib/ltemplate.py | 29 ++++++++++-------------------
 1 file changed, 10 insertions(+), 19 deletions(-)

diff --git a/tests/topotests/lib/ltemplate.py b/tests/topotests/lib/ltemplate.py
index c141ef7585..30ff2cd7f6 100644
--- a/tests/topotests/lib/ltemplate.py
+++ b/tests/topotests/lib/ltemplate.py
@@ -43,15 +43,18 @@ from mininet.topo import Topo
 customize = None
 
 class LTemplate():
-    scriptdir = None
     test = None
     testdir = None
+    scriptdir = None
+    logdir = None
 
     def __init__(self, test, testdir):
         global customize
         customize = imp.load_source('customize', os.path.join(testdir, 'customize.py'))
         self.test = test
         self.testdir = testdir
+        self.scriptdir = testdir
+        self.logdir = '/tmp/topotests/{0}.test_{0}'.format(test)
         logger.info('LTemplate: '+test)
 
     def setup_module(self, mod):
@@ -95,6 +98,7 @@ class LTemplate():
         except NameError:
             #not defined
             logger.debug("ltemplatePostRouterStartHook() not defined")
+        luStart(baseScriptDir=self.scriptdir, baseLogDir=self.logdir, net=tgen.net)
 
 #initialized by ltemplate_start
 _lt = None
@@ -122,19 +126,16 @@ def setup_module(mod):
     #sys.path.remove(testdir)
 
 def teardown_module(mod):
+    global _lt
     "Teardown the pytest environment"
     tgen = get_topogen()
 
+    if _lt != None and _lt.scriptdir != None:
+        print(luFinish())
+
     # This function tears down the whole topology.
     tgen.stop_topology()
-
-def ltemplate_start(testDir):
-    logger.info('ltemplate start in ' + testDir)
-    test = os.path.basename(testDir)
-    logDir = '/tmp/topotests/{0}.test_{0}'.format(test)
-    tgen = get_topogen()
-    luStart(baseScriptDir=testDir, baseLogDir=logDir, net=tgen.net)
-    _lt.scriptdir = testDir
+    _lt = None
 
 def ltemplateTest(script, SkipIfFailed=True, CallOnFail=None, CheckFuncStr=None):
     tgen = get_topogen()
@@ -173,16 +174,6 @@ def test_memory_leak():
 
     tgen.report_memory_leaks()
 
-#clean up ltemplate
-
-def test_ltemplate_finish():
-    global _lt
-    logger.info('Done with ltemplate tests')
-    if _lt != None and _lt.scriptdir != None:
-        print(luFinish())
-    #done
-    _lt = None
-
 #for testing
 if __name__ == '__main__':
     args = ["-s"] + sys.argv[1:]
-- 
2.39.5