From 81c077d096b60ad4bf25e52628affe02886e6d2d Mon Sep 17 00:00:00 2001 From: Quentin Young Date: Tue, 26 Feb 2019 20:35:29 +0000 Subject: [PATCH] pimd: strncpy -> strlcpy strncpy is a byte copy function not a string copy function Signed-off-by: Quentin Young --- pimd/pim_register.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pimd/pim_register.c b/pimd/pim_register.c index b9908ae22b..4b402de634 100644 --- a/pimd/pim_register.c +++ b/pimd/pim_register.c @@ -189,8 +189,8 @@ void pim_register_send(const uint8_t *buf, int buf_size, struct in_addr src, if (PIM_DEBUG_PIM_REG) { char rp_str[INET_ADDRSTRLEN]; - strncpy(rp_str, inet_ntoa(rpg->rpf_addr.u.prefix4), - INET_ADDRSTRLEN - 1); + strlcpy(rp_str, inet_ntoa(rpg->rpf_addr.u.prefix4), + sizeof(rp_str)); zlog_debug("%s: Sending %s %sRegister Packet to %s on %s", __PRETTY_FUNCTION__, up->sg_str, null_register ? "NULL " : "", rp_str, ifp->name); -- 2.39.5