From 804fb5c1e5a01bc522c2d6f6d0b64c78f0484a45 Mon Sep 17 00:00:00 2001 From: Donald Sharp Date: Tue, 19 May 2015 18:03:59 -0700 Subject: [PATCH] If on-shutdown is configured to a large value and 'service quagga restart' is executed, then the init.d/quagga script doesnt wait more than 120 seconds for the daemon do stop, worse, it goes ahead and starts the new daemon regardless. This can result into two ospfd processes running on the same config. Which leads to many issues including but not limited to high cpu usage. Thats because the two processes are mixing packets on adjancencies thus causing churn on the box and network. As long as OSPF is able to reliably send the max-metric router-lsa before exiting thats mostly good enough for this purpose anyways. As a solution to this situation, bringing the maximum configurable value of the on-shutdown timer below the maximum retry to stop a daemon in init.d/quagga Notes: This may not be an upstreamable patch, still we needed to find a solution for init.d/quagga and this command this co-exist. --- ospfd/ospf_vty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ospfd/ospf_vty.c b/ospfd/ospf_vty.c index 2645d24d3a..109da255a1 100644 --- a/ospfd/ospf_vty.c +++ b/ospfd/ospf_vty.c @@ -7372,7 +7372,7 @@ DEFUN (no_ospf_max_metric_router_lsa_startup, DEFUN (ospf_max_metric_router_lsa_shutdown, ospf_max_metric_router_lsa_shutdown_cmd, - "max-metric router-lsa on-shutdown <5-86400>", + "max-metric router-lsa on-shutdown <5-100>", "OSPF maximum / infinite-distance metric\n" "Advertise own Router-LSA with infinite distance (stub router)\n" "Advertise stub-router prior to full shutdown of OSPF\n" -- 2.39.5