From 7e678379edb62b1a2e75131ef3a9fae701fbcc37 Mon Sep 17 00:00:00 2001 From: Lou Berger Date: Tue, 28 Aug 2018 17:14:14 -0400 Subject: [PATCH] doc: add comment on closing PRs Signed-off-by: Lou Berger --- doc/developer/workflow.rst | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/doc/developer/workflow.rst b/doc/developer/workflow.rst index 5a88ac8d1f..d316de0f38 100644 --- a/doc/developer/workflow.rst +++ b/doc/developer/workflow.rst @@ -335,6 +335,11 @@ Guidelines for code review - For a PR you marked with "Changes requested", please respond to updates in a timely manner to avoid impeding the flow of development. +- Rejected or obsolete PRs are generally closed by the submitter based + on requests and/or agreement captured in a PR comment. The comment + may originate with a reviewer or document agreement reached on Slack, + the Development mailing list, or the weekly technical meeting. + Coding Practices & Style ======================== -- 2.39.5