From 790fae0ca9a0d980f4e7c840b50f504a88acab54 Mon Sep 17 00:00:00 2001 From: Igor Ryzhov Date: Sun, 17 Mar 2024 22:44:28 +0200 Subject: [PATCH] lib: remove nb/yang memory cleanup when daemonizing We're not calling any other termination functions to free allocated memory when daemonizing except these two. There's no reason for such an exception, and because of these calls we have the following libyang warnings every time FRR is started: ``` MGMTD: libyang: String "15" not freed from the dictionary, refcount 2 MGMTD: libyang: String "200" not freed from the dictionary, refcount 2 MGMTD: libyang: String "mrib-then-urib" not freed from the dictionary, refcount 2 MGMTD: libyang: String "1000" not freed from the dictionary, refcount 2 MGMTD: libyang: String "10" not freed from the dictionary, refcount 2 MGMTD: libyang: String "5" not freed from the dictionary, refcount 2 ``` Remove these calls to get rid of the unnecessary warnings. Signed-off-by: Igor Ryzhov (cherry picked from commit a564710c34bdae8a0f0630f50b5718f0757d8edc) --- lib/libfrr.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/libfrr.c b/lib/libfrr.c index 9e472054dd..2861ebe0b9 100644 --- a/lib/libfrr.c +++ b/lib/libfrr.c @@ -957,8 +957,6 @@ static void frr_daemonize(void) } close(fds[1]); - nb_terminate(); - yang_terminate(); frr_daemon_wait(fds[0]); } -- 2.39.5