From 7012f1a38cdce2bcb58ed538cac6cca77927e59c Mon Sep 17 00:00:00 2001 From: Quentin Young Date: Mon, 2 Jul 2018 18:07:28 +0000 Subject: [PATCH] zebra: remove asserts on task nullity While ZAPI I/O threads make a best effort to kill any scheduled tasks on their threadmasters, after death another pthread can continue to schedule onto the threadmaster. This isn't a problem per se since the tasks will never run, but it also means that asserting that it hasn't happened is pointless. Signed-off-by: Quentin Young --- zebra/zserv.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/zebra/zserv.c b/zebra/zserv.c index b297f75ed9..434a1507ae 100644 --- a/zebra/zserv.c +++ b/zebra/zserv.c @@ -618,14 +618,6 @@ static int zserv_handle_client_close(struct thread *thread) { struct zserv *client = THREAD_ARG(thread); - /* - * Ensure these have been nulled. This does not equate to the - * associated task(s) being scheduled or unscheduled on the client - * pthread's threadmaster. - */ - assert(!client->t_read); - assert(!client->t_write); - /* synchronously stop thread */ frr_pthread_stop(client->pthread, NULL); -- 2.39.5