From 6ea591c70044e6af9a3f2a80bfeef015884cf192 Mon Sep 17 00:00:00 2001 From: "F. Aragon" Date: Thu, 20 Sep 2018 16:00:40 +0200 Subject: [PATCH] bgpd: null check (Coverity 1472965 1472966) There were checks for null pointer after being dereferenced. Checks have been removed (we've discussed the no need of adding assert()'s because of similar code not requiring them). Signed-off-by: F. Aragon --- bgpd/bgp_pbr.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/bgpd/bgp_pbr.c b/bgpd/bgp_pbr.c index 552eb253ea..a74b584e90 100644 --- a/bgpd/bgp_pbr.c +++ b/bgpd/bgp_pbr.c @@ -1882,14 +1882,14 @@ static void bgp_pbr_policyroute_add_to_zebra_unit(struct bgp *bgp, } /* ipset create */ - if (bpm && !bpm->installed) + if (!bpm->installed) bgp_send_pbr_ipset_match(bpm, true); /* ipset add */ - if (bpme && !bpme->installed) + if (!bpme->installed) bgp_send_pbr_ipset_entry_match(bpme, true); /* iptables */ - if (bpm && !bpm->installed_in_iptable) + if (!bpm->installed_in_iptable) bgp_send_pbr_iptable(bpa, bpm, true); /* A previous entry may already exist -- 2.39.5