From 6d5769a27ab634d90158e870826d067e3b6527f0 Mon Sep 17 00:00:00 2001 From: Quentin Young Date: Wed, 2 Feb 2022 16:34:03 -0500 Subject: [PATCH] bgpd: strncmp -> strcmp in community hash foo buffers are null terminated Signed-off-by: Quentin Young (cherry picked from commit c975f1a5e405f7a74d45519862388cd9ea8ce782) --- bgpd/bgp_community_alias.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/bgpd/bgp_community_alias.c b/bgpd/bgp_community_alias.c index 793f3ac9ac..2c86efb5a0 100644 --- a/bgpd/bgp_community_alias.c +++ b/bgpd/bgp_community_alias.c @@ -40,9 +40,7 @@ static bool bgp_ca_community_hash_cmp(const void *p1, const void *p2) const struct community_alias *ca1 = p1; const struct community_alias *ca2 = p2; - return (strncmp(ca1->community, ca2->community, - sizeof(struct community_alias)) - == 0); + return (strcmp(ca1->community, ca2->community) == 0); } static unsigned int bgp_ca_alias_hash_key(const void *p) @@ -57,8 +55,7 @@ static bool bgp_ca_alias_hash_cmp(const void *p1, const void *p2) const struct community_alias *ca1 = p1; const struct community_alias *ca2 = p2; - return (strncmp(ca1->alias, ca2->alias, sizeof(struct community_alias)) - == 0); + return (strcmp(ca1->alias, ca2->alias) == 0); } static void *bgp_community_alias_alloc(void *p) -- 2.39.5