From 67e5d67651bd94b52e33442308158a415e43f39f Mon Sep 17 00:00:00 2001 From: Martin Winter Date: Fri, 3 Feb 2017 18:09:36 +0700 Subject: [PATCH] ospfd: Fix Coverity Warning CID 1399480 (#1 of 1): Buffer not null terminated (BUFFER_SIZE_WARNING) Coverity: buffer_size_warning: Calling strncpy with a maximum size argument of 100 bytes on destination array pid_file of size 100 bytes might leave the destination string unterminated. Signed-off-by: Martin Winter --- ospfd/ospf_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ospfd/ospf_main.c b/ospfd/ospf_main.c index 845d96032b..cc335a8abd 100644 --- a/ospfd/ospf_main.c +++ b/ospfd/ospf_main.c @@ -383,7 +383,7 @@ main (int argc, char **argv) pid_file[0] = '\0'; snprintf(pidfile_temp, sizeof(pidfile_temp), "%s/ospfd-%d.pid", pid_file, instance ); - strncpy(pid_file, pidfile_temp, sizeof(pid_file)); + strlcpy(pid_file, pidfile_temp, sizeof(pid_file)); } /* Process id file create. */ pid_output (pid_file); -- 2.39.5