From 67533c11d2069bcf65a08a84e26fba900448f4ea Mon Sep 17 00:00:00 2001 From: Vincent JARDIN Date: Mon, 9 Oct 2017 10:51:03 +0200 Subject: [PATCH] lib: linklist avoid access NULL->data Let's assert(NULL) if the datastructure is not set. The code assumes that the pointer is always non NULL. So, let's enforce this semantic. Signed-off-by: Vincent Jardin --- lib/linklist.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/linklist.h b/lib/linklist.h index 4a65fead86..8a43fbe64b 100644 --- a/lib/linklist.h +++ b/lib/linklist.h @@ -56,7 +56,8 @@ struct list { #define listtail(X) ((X) ? ((X)->tail) : NULL) #define listcount(X) ((X)->count) #define list_isempty(X) ((X)->head == NULL && (X)->tail == NULL) -#define listgetdata(X) (assert((X)->data != NULL), (X)->data) +/* return X->data only if X and X->data are not NULL */ +#define listgetdata(X) (assert(X), assert((X)->data != NULL), (X)->data) /* Prototypes. */ extern struct list * -- 2.39.5