From 5ecf5540097c30ab0b02b3ac18133b17e660c9db Mon Sep 17 00:00:00 2001 From: Renato Westphal Date: Tue, 22 Aug 2017 20:09:26 -0300 Subject: [PATCH] bgpd: fix file descriptor leak Bug introduced by commit 37d361e7. Removing the call to bgp_close() from bgp_delete() was a mistake. Reported-by: Don Slice Signed-off-by: Renato Westphal --- bgpd/bgpd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/bgpd/bgpd.c b/bgpd/bgpd.c index 9d7c38c871..e3650417fa 100644 --- a/bgpd/bgpd.c +++ b/bgpd/bgpd.c @@ -3087,6 +3087,8 @@ int bgp_delete(struct bgp *bgp) * routes to be processed still referencing the struct bgp. */ listnode_delete(bm->bgp, bgp); + if (list_isempty(bm->bgp)) + bgp_close(); /* Deregister from Zebra, if needed */ if (IS_BGP_INST_KNOWN_TO_ZEBRA(bgp)) -- 2.39.5