From 578c0b134c751196f7ad53a1cb53d3518ef09472 Mon Sep 17 00:00:00 2001 From: Donald Sharp Date: Thu, 16 Feb 2023 09:06:59 -0500 Subject: [PATCH] zebra: Ensure bvlan is non null Coverity rightly points out that a call into zebra_l2_bridge_if_vlan_find is NULL checked 4/5 times. Let's make it 5/5 Signed-off-by: Donald Sharp --- zebra/zebra_l2_bridge_if.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/zebra/zebra_l2_bridge_if.c b/zebra/zebra_l2_bridge_if.c index 6574899927..b85d39bcd6 100644 --- a/zebra/zebra_l2_bridge_if.c +++ b/zebra/zebra_l2_bridge_if.c @@ -209,6 +209,8 @@ static int zebra_l2_bridge_if_vlan_update(struct interface *ifp, zif = (struct zebra_if *)ifp->info; bvlan = zebra_l2_bridge_if_vlan_find(zif, bvl->vid); + if (!bvlan) + return 0; if (chgflags & ZEBRA_BRIDGEIF_ACCESS_BD_CHANGE) bvlan->access_bd = bvl->access_bd; -- 2.39.5