From 4cce733fc200ebb69fccacc35fde9aa9b7264ad3 Mon Sep 17 00:00:00 2001 From: Igor Ryzhov Date: Wed, 3 Mar 2021 19:38:38 +0300 Subject: [PATCH] bfdd: require local-address when using multihop If local-address is not supplied, then an incorrect xpath is generated which is not expected by NB CLI. Fixes #7465. Signed-off-by: Igor Ryzhov --- bfdd/bfdd_cli.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/bfdd/bfdd_cli.c b/bfdd/bfdd_cli.c index b9e7903613..84354e243d 100644 --- a/bfdd/bfdd_cli.c +++ b/bfdd/bfdd_cli.c @@ -117,10 +117,14 @@ DEFPY_YANG_NOSH( char source_str[INET6_ADDRSTRLEN + 32]; char xpath[XPATH_MAXLEN], xpath_srcaddr[XPATH_MAXLEN + 32]; - if (multihop) + if (multihop) { + if (!local_address_str) { + vty_out(vty, "%% local-address is required when using multihop\n"); + return CMD_WARNING_CONFIG_FAILED; + } snprintf(source_str, sizeof(source_str), "[source-addr='%s']", local_address_str); - else + } else source_str[0] = 0; slen = snprintf(xpath, sizeof(xpath), -- 2.39.5