From 4b2e09df96c263009fd1061fbc3cc8ade9b62051 Mon Sep 17 00:00:00 2001 From: Donald Sharp Date: Tue, 23 Nov 2021 20:16:29 -0500 Subject: [PATCH] tests: Do not pick an ip address that overlaps with ourselves The ospf_basic_functionality/test_ospf_lan.py creates a ethernet segment and attaches 4 routers to it and assigns ip addresses in a /24. As one of the tests it picks a new address for r0 which coincides with a ip address on r3. Then the test immediatly checks for other data. The problem is of course that if a test is `slow` enough hello's will start to be ignored from r3 to r0 and the neighbor relationships will come down. Choose an ip address that doesn't cause this issue. Signed-off-by: Donald Sharp --- tests/topotests/ospf_basic_functionality/test_ospf_lan.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/topotests/ospf_basic_functionality/test_ospf_lan.py b/tests/topotests/ospf_basic_functionality/test_ospf_lan.py index b80da41bec..fd17180051 100644 --- a/tests/topotests/ospf_basic_functionality/test_ospf_lan.py +++ b/tests/topotests/ospf_basic_functionality/test_ospf_lan.py @@ -408,7 +408,7 @@ def test_ospf_lan_tc1_p0(request): topo_modify_change_ip = deepcopy(topo) intf_ip = topo_modify_change_ip["routers"]["r0"]["links"]["s1"]["ipv4"] topo_modify_change_ip["routers"]["r0"]["links"]["s1"]["ipv4"] = str( - IPv4Address(frr_unicode(intf_ip.split("/")[0])) + 3 + IPv4Address(frr_unicode(intf_ip.split("/")[0])) + 4 ) + "/{}".format(intf_ip.split("/")[1]) build_config_from_json(tgen, topo_modify_change_ip, save_bkup=False) -- 2.39.5