From 4848ef7430f9b7f48141d20f8c8cab2dc8dd34aa Mon Sep 17 00:00:00 2001 From: "F. Aragon" Date: Wed, 26 Sep 2018 17:50:33 +0200 Subject: [PATCH] bfdd zebra: dead code (Coverity 1472624 1473199) Signed-off-by: F. Aragon --- bfdd/bfdd_vty.c | 9 +-------- zebra/zebra_vxlan.c | 6 ++---- 2 files changed, 3 insertions(+), 12 deletions(-) diff --git a/bfdd/bfdd_vty.c b/bfdd/bfdd_vty.c index 1c6d03195c..51dd9cb26d 100644 --- a/bfdd/bfdd_vty.c +++ b/bfdd/bfdd_vty.c @@ -886,14 +886,7 @@ static int bfd_configure_peer(struct bfd_peer_cfg *bpc, bool mhop, if (local) bpc->bpc_local = *local; - if (peer) { - bpc->bpc_peer = *peer; - } else { - /* Peer configuration is mandatory. */ - snprintf(ebuf, ebuflen, "no peer configured"); - return -1; - } - + bpc->bpc_peer = *peer; bpc->bpc_mhop = mhop; /* Handle interface specification configuration. */ diff --git a/zebra/zebra_vxlan.c b/zebra/zebra_vxlan.c index ea0bef3718..989d63f9b1 100644 --- a/zebra/zebra_vxlan.c +++ b/zebra/zebra_vxlan.c @@ -4269,10 +4269,8 @@ static void process_remote_macip_add(vni_t vni, vni, prefix_mac2str(macaddr, buf, sizeof(buf)), - ipa_len ? " IP " : "", - ipa_len ? - ipaddr2str(ipaddr, - buf1, sizeof(buf1)) : "", + " IP ", + ipaddr2str(ipaddr, buf1, sizeof(buf1)), n_type, tmp_seq); return; -- 2.39.5