From 45f64029dcb4f07a4abf896bc7f564babe973a66 Mon Sep 17 00:00:00 2001 From: Renato Westphal Date: Wed, 15 Jun 2022 11:39:48 -0300 Subject: [PATCH] tests: fix ldp_vpls_topo1 to work as expected In the last step of this test, r1's link to r2 is shut down but both routers stay connected through a multi-hop LDP session. That happens because r1 and r2 have a targeted adjacency created by the pseudowire. The test then checks whether the pseudowire is still up, using an alternate path for nexthop resolution. Everything's fine except for the fact that LDP GTSM (aka ttl-security) is enabled by default. This means that messages sent over a multi-hop session are not delivered. In the case of this test, it can prevent PW-Status notifications from being delivered, which in turn can prevent the pseudowire from coming back up. Fix the test by disabling GTSM so that LDP multi-hop sessions can work normally. This is in accordance with RFC6720 which mentions that GTSM should be disabled (statically or dynamically) for multi-hop sessions. Signed-off-by: Renato Westphal --- tests/topotests/ldp_vpls_topo1/r1/ldpd.conf | 1 + tests/topotests/ldp_vpls_topo1/r2/ldpd.conf | 1 + tests/topotests/ldp_vpls_topo1/r3/ldpd.conf | 1 + 3 files changed, 3 insertions(+) diff --git a/tests/topotests/ldp_vpls_topo1/r1/ldpd.conf b/tests/topotests/ldp_vpls_topo1/r1/ldpd.conf index 594ec5a58f..a19e5ccacb 100644 --- a/tests/topotests/ldp_vpls_topo1/r1/ldpd.conf +++ b/tests/topotests/ldp_vpls_topo1/r1/ldpd.conf @@ -14,6 +14,7 @@ mpls ldp ! address-family ipv4 discovery transport-address 1.1.1.1 + ttl-security disable label local allocate host-routes ! interface r1-eth1 diff --git a/tests/topotests/ldp_vpls_topo1/r2/ldpd.conf b/tests/topotests/ldp_vpls_topo1/r2/ldpd.conf index ffb4f0974a..447b3f140a 100644 --- a/tests/topotests/ldp_vpls_topo1/r2/ldpd.conf +++ b/tests/topotests/ldp_vpls_topo1/r2/ldpd.conf @@ -14,6 +14,7 @@ mpls ldp ! address-family ipv4 discovery transport-address 2.2.2.2 + ttl-security disable label local allocate host-routes ! interface r2-eth1 diff --git a/tests/topotests/ldp_vpls_topo1/r3/ldpd.conf b/tests/topotests/ldp_vpls_topo1/r3/ldpd.conf index c95471ffd8..ab51471499 100644 --- a/tests/topotests/ldp_vpls_topo1/r3/ldpd.conf +++ b/tests/topotests/ldp_vpls_topo1/r3/ldpd.conf @@ -14,6 +14,7 @@ mpls ldp ! address-family ipv4 discovery transport-address 3.3.3.3 + ttl-security disable label local allocate host-routes ! interface r3-eth1 -- 2.39.5