From 3f788da60b9f93919ac4ebe0df82fc4c89c4dcb1 Mon Sep 17 00:00:00 2001
From: Donatas Abraitis <donatas@opensourcerouting.org>
Date: Wed, 29 Jan 2025 23:11:35 +0200
Subject: [PATCH] tests: Check if the peer stays Idle if router-id is not set

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
(cherry picked from commit 48560b5c9b8084e903ebf0ef5987b4e581459608)
---
 .../bgp_ipv6_ll_peering/r1/bgpd.conf          |  3 ++
 .../bgp_ipv6_ll_peering/r1/zebra.conf         |  3 ++
 .../bgp_ipv6_ll_peering/r3/bgpd.conf          |  5 ++++
 .../bgp_ipv6_ll_peering/r3/zebra.conf         |  4 +++
 .../test_bgp_ipv6_ll_peering.py               | 29 ++++++++++++++++++-
 5 files changed, 43 insertions(+), 1 deletion(-)
 create mode 100644 tests/topotests/bgp_ipv6_ll_peering/r3/bgpd.conf
 create mode 100644 tests/topotests/bgp_ipv6_ll_peering/r3/zebra.conf

diff --git a/tests/topotests/bgp_ipv6_ll_peering/r1/bgpd.conf b/tests/topotests/bgp_ipv6_ll_peering/r1/bgpd.conf
index 724cbf84ab..a26efb4c4f 100644
--- a/tests/topotests/bgp_ipv6_ll_peering/r1/bgpd.conf
+++ b/tests/topotests/bgp_ipv6_ll_peering/r1/bgpd.conf
@@ -4,3 +4,6 @@ router bgp 65001
  neighbor fe80:1::2 remote-as external
  neighbor fe80:1::2 timers 3 10
  neighbor fe80:1::2 interface r1-eth0
+ neighbor fe80:1::3 remote-as external
+ neighbor fe80:1::3 timers 3 10
+ neighbor fe80:1::3 interface r1-eth1
diff --git a/tests/topotests/bgp_ipv6_ll_peering/r1/zebra.conf b/tests/topotests/bgp_ipv6_ll_peering/r1/zebra.conf
index 4e93d4f4e5..f1bbff2e44 100644
--- a/tests/topotests/bgp_ipv6_ll_peering/r1/zebra.conf
+++ b/tests/topotests/bgp_ipv6_ll_peering/r1/zebra.conf
@@ -2,3 +2,6 @@
 interface r1-eth0
  ipv6 address fe80:1::1/64
 !
+interface r1-eth1
+ ipv6 address fe80:1::1/64
+!
diff --git a/tests/topotests/bgp_ipv6_ll_peering/r3/bgpd.conf b/tests/topotests/bgp_ipv6_ll_peering/r3/bgpd.conf
new file mode 100644
index 0000000000..f1684880b3
--- /dev/null
+++ b/tests/topotests/bgp_ipv6_ll_peering/r3/bgpd.conf
@@ -0,0 +1,5 @@
+router bgp 65003
+ no bgp ebgp-requires-policy
+ neighbor fe80:1::1 remote-as external
+ neighbor fe80:1::1 timers 3 10
+ neighbor fe80:1::1 interface r3-eth0
diff --git a/tests/topotests/bgp_ipv6_ll_peering/r3/zebra.conf b/tests/topotests/bgp_ipv6_ll_peering/r3/zebra.conf
new file mode 100644
index 0000000000..71053cd2c3
--- /dev/null
+++ b/tests/topotests/bgp_ipv6_ll_peering/r3/zebra.conf
@@ -0,0 +1,4 @@
+!
+interface r3-eth0
+ ipv6 address fe80:1::3/64
+!
diff --git a/tests/topotests/bgp_ipv6_ll_peering/test_bgp_ipv6_ll_peering.py b/tests/topotests/bgp_ipv6_ll_peering/test_bgp_ipv6_ll_peering.py
index aaa68ea340..fbd4097605 100644
--- a/tests/topotests/bgp_ipv6_ll_peering/test_bgp_ipv6_ll_peering.py
+++ b/tests/topotests/bgp_ipv6_ll_peering/test_bgp_ipv6_ll_peering.py
@@ -27,13 +27,17 @@ pytestmark = [pytest.mark.bgpd]
 
 
 def build_topo(tgen):
-    for routern in range(1, 3):
+    for routern in range(1, 4):
         tgen.add_router("r{}".format(routern))
 
     switch = tgen.add_switch("s1")
     switch.add_link(tgen.gears["r1"])
     switch.add_link(tgen.gears["r2"])
 
+    switch = tgen.add_switch("s2")
+    switch.add_link(tgen.gears["r1"])
+    switch.add_link(tgen.gears["r3"])
+
 
 def setup_module(mod):
     tgen = Topogen(build_topo, mod.__name__)
@@ -64,6 +68,7 @@ def test_bgp_ipv6_link_local_peering():
         pytest.skip(tgen.errors)
 
     r1 = tgen.gears["r1"]
+    r3 = tgen.gears["r3"]
 
     def _bgp_converge():
         output = json.loads(r1.vtysh_cmd("show bgp summary json"))
@@ -82,6 +87,28 @@ def test_bgp_ipv6_link_local_peering():
     _, result = topotest.run_and_expect(test_func, None, count=60, wait=0.5)
     assert result is None, "Failed to see BGP convergence on R2"
 
+    def _bgp_router_id_missing():
+        output = json.loads(r3.vtysh_cmd("show bgp summary failed json"))
+        expected = {
+            "ipv4Unicast": {
+                "routerId": "0.0.0.0",
+                "as": 65003,
+                "peers": {
+                    "fe80:1::1": {
+                        "connectionsEstablished": 0,
+                        "connectionsDropped": 0,
+                        "peerUptime": "never",
+                        "lastResetDueTo": "Router ID is missing",
+                    }
+                },
+            }
+        }
+        return topotest.json_cmp(output, expected)
+
+    test_func = functools.partial(_bgp_router_id_missing)
+    _, result = topotest.run_and_expect(test_func, None, count=60, wait=0.5)
+    assert result is None, "r3 should stay down due to missing router ID"
+
 
 if __name__ == "__main__":
     args = ["-s"] + sys.argv[1:]
-- 
2.39.5