From 3a6570a1f145c49155d72a815441025085dd45ad Mon Sep 17 00:00:00 2001
From: Hung-Weic Chiu <sppsorrg@gmail.com>
Date: Sat, 29 Apr 2017 15:25:32 +0000
Subject: [PATCH] Fix the "Dead assignment" of clang SA.

- Remove duplicated assignemt.
- Remove unused initialized.

Signed-off-by: Hung-Weic Chiu <sppsorrg@gmail.com>
---
 ospfd/ospf_apiserver.c | 2 +-
 ospfd/ospf_vty.c       | 9 ---------
 pimd/pim_register.c    | 4 ++--
 3 files changed, 3 insertions(+), 12 deletions(-)

diff --git a/ospfd/ospf_apiserver.c b/ospfd/ospf_apiserver.c
index aac8ef4b8b..620dacb157 100644
--- a/ospfd/ospf_apiserver.c
+++ b/ospfd/ospf_apiserver.c
@@ -2459,7 +2459,7 @@ ospf_apiserver_clients_notify_nsm_change (struct ospf_neighbor *nbr)
 {
   struct msg *msg;
   struct in_addr ifaddr = { .s_addr = 0L };
-  struct in_addr nbraddr = { .s_addr = 0L };
+  struct in_addr nbraddr;
 
   assert (nbr);
 
diff --git a/ospfd/ospf_vty.c b/ospfd/ospf_vty.c
index 5faf2850d9..38e006e928 100644
--- a/ospfd/ospf_vty.c
+++ b/ospfd/ospf_vty.c
@@ -6758,7 +6758,6 @@ DEFUN (no_ip_ospf_cost,
   int ret;
   struct ospf_if_params *params;
   
-  ifp = vty->index;
   params = IF_DEF_PARAMS (ifp);
 
   if (argc == 1)
@@ -6827,7 +6826,6 @@ DEFUN (no_ip_ospf_cost2,
   int ret;
   struct ospf_if_params *params;
 
-  ifp = vty->index;
   params = IF_DEF_PARAMS (ifp);
 
   /* According to the semantics we are mimicking "no ip ospf cost N" is
@@ -7067,7 +7065,6 @@ DEFUN (no_ip_ospf_dead_interval,
   struct ospf_interface *oi;
   struct route_node *rn;
 
-  ifp = vty->index;
   params = IF_DEF_PARAMS (ifp);
 
   if (argc == 2)
@@ -7242,7 +7239,6 @@ DEFUN (no_ip_ospf_hello_interval,
   int ret;
   struct ospf_if_params *params;
   
-  ifp = vty->index;
   params = IF_DEF_PARAMS (ifp);
 
   if (argc == 2)
@@ -7520,7 +7516,6 @@ DEFUN (no_ip_ospf_priority,
   int ret;
   struct ospf_if_params *params;
   
-  ifp = vty->index;
   params = IF_DEF_PARAMS (ifp);
 
   if (argc == 2)
@@ -7667,7 +7662,6 @@ DEFUN (no_ip_ospf_retransmit_interval,
   struct ospf_if_params *params;
   int addr_index;
   
-  ifp = vty->index;
   params = IF_DEF_PARAMS (ifp);
 
   if (argc >= 1)
@@ -7739,7 +7733,6 @@ DEFUN (no_ip_ospf_retransmit_interval_sec,
   struct interface *ifp = vty->index;
   struct ospf_if_params *params;
 
-  ifp = vty->index;
   params = IF_DEF_PARAMS (ifp);
 
   UNSET_IF_PARAM (params, retransmit_interval);
@@ -7824,7 +7817,6 @@ DEFUN (no_ip_ospf_transmit_delay,
   struct ospf_if_params *params;
   int addr_index;
   
-  ifp = vty->index;
   params = IF_DEF_PARAMS (ifp);
 
   if (argc >= 1)
@@ -7897,7 +7889,6 @@ DEFUN (no_ip_ospf_transmit_delay_sec,
   struct interface *ifp = vty->index;
   struct ospf_if_params *params;
 
-  ifp = vty->index;
   params = IF_DEF_PARAMS (ifp);
 
   UNSET_IF_PARAM (params, transmit_delay);
diff --git a/pimd/pim_register.c b/pimd/pim_register.c
index ce3ac1a433..7844bd3399 100644
--- a/pimd/pim_register.c
+++ b/pimd/pim_register.c
@@ -160,8 +160,8 @@ pim_register_recv (struct interface *ifp,
   int sentRegisterStop = 0;
   struct ip *ip_hdr;
   //size_t hlen;
-  struct in_addr group = { .s_addr = 0 };
-  struct in_addr source = { .s_addr = 0 };
+  struct in_addr group;
+  struct in_addr source;
   //uint8_t *msg;
   uint32_t *bits;
 
-- 
2.39.5