From 2fd89ed7fc4b935cc9afeb6848fb74c24f1f75cd Mon Sep 17 00:00:00 2001 From: Donald Sharp Date: Tue, 5 Dec 2017 09:52:16 -0500 Subject: [PATCH] eigrpd: Fixup some SA issues 1) strlen(buf) on an uninted value is the wrong thing to do we should be getting sizeof(buf) 2) tlv is not freed in this error case, so let's free it up. Signed-off-by: Donald Sharp --- eigrpd/eigrp_reply.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/eigrpd/eigrp_reply.c b/eigrpd/eigrp_reply.c index 0ccffde72b..84396f0878 100644 --- a/eigrpd/eigrp_reply.c +++ b/eigrpd/eigrp_reply.c @@ -170,9 +170,11 @@ void eigrp_reply_receive(struct eigrp *eigrp, struct ip *iph, */ if (!dest) { char buf[PREFIX_STRLEN]; + zlog_err("%s: Received prefix %s which we do not know about", __PRETTY_FUNCTION__, - prefix2str(&dest_addr, buf, strlen(buf))); + prefix2str(&dest_addr, buf, sizeof(buf))); + eigrp_IPv4_InternalTLV_free(tlv); continue; } -- 2.39.5