From 2d423186259246cba7ba0aaceab2f70a4bce00f0 Mon Sep 17 00:00:00 2001 From: Mark Stapp Date: Wed, 16 Apr 2025 11:39:26 -0400 Subject: [PATCH] bfdd, bgpd: clean up clang warnings Clean up some clang compiler warnings. Signed-off-by: Mark Stapp --- bfdd/bfd.c | 2 +- bgpd/bgp_bmp.c | 9 ++++----- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/bfdd/bfd.c b/bfdd/bfd.c index e538aa64c2..f199970e20 100644 --- a/bfdd/bfd.c +++ b/bfdd/bfd.c @@ -2518,7 +2518,7 @@ void sbfd_reflector_free(const uint32_t discr) return; } -void sbfd_reflector_flush() +void sbfd_reflector_flush(void) { sbfd_discr_iterate(_sbfd_reflector_free, NULL); return; diff --git a/bgpd/bgp_bmp.c b/bgpd/bgp_bmp.c index b1bff82b05..e09e7b4941 100644 --- a/bgpd/bgp_bmp.c +++ b/bgpd/bgp_bmp.c @@ -3542,7 +3542,6 @@ static int bmp_bgp_attribute_updated(struct bgp *bgp, bool withdraw) struct bmp_targets *bt; struct listnode *node; struct bmp_imported_bgp *bib; - int ret = 0; struct stream *s = bmp_peerstate(bgp->peer_self, withdraw); struct bmp *bmp; afi_t afi; @@ -3553,8 +3552,8 @@ static int bmp_bgp_attribute_updated(struct bgp *bgp, bool withdraw) if (bmpbgp) { frr_each (bmp_targets, &bmpbgp->targets, bt) { - ret = bmp_bgp_attribute_updated_instance(bt, &bmpbgp->vrf_state, bgp, - withdraw, s); + bmp_bgp_attribute_updated_instance(bt, &bmpbgp->vrf_state, bgp, + withdraw, s); if (withdraw) continue; frr_each (bmp_session, &bt->sessions, bmp) { @@ -3575,8 +3574,8 @@ static int bmp_bgp_attribute_updated(struct bgp *bgp, bool withdraw) frr_each (bmp_imported_bgps, &bt->imported_bgps, bib) { if (bgp_lookup_by_name(bib->name) != bgp) continue; - ret += bmp_bgp_attribute_updated_instance(bt, &bib->vrf_state, bgp, - withdraw, s); + bmp_bgp_attribute_updated_instance(bt, &bib->vrf_state, bgp, + withdraw, s); if (withdraw) continue; frr_each (bmp_session, &bt->sessions, bmp) { -- 2.39.5