From 26eddfd5666be3180393e6c9e3879f0f94351167 Mon Sep 17 00:00:00 2001 From: Donatas Abraitis Date: Fri, 1 Sep 2023 17:10:12 +0300 Subject: [PATCH] bgpd: Treat as4-path (17) attribute as withdraw if malformed rfc7606 defines: Attributes 17 (AS4_PATH), 18 (AS4_AGGREGATOR), 22 (PMSI_TUNNEL), 23 (Tunnel Encapsulation Attribute), 26 (AIGP), 27 (PE Distinguisher Labels), and 29 (BGP-LS Attribute) do have error handling consistent with Section 8 and thus are not further discussed herein. Section 8 defines: The "treat-as-withdraw" approach is generally preferred and the "session reset" approach is discouraged. For any malformed attribute that is handled by the "attribute discard" instead of the "treat-as-withdraw" approach, it is critical to consider the potential impact of doing so. Signed-off-by: Donatas Abraitis (cherry picked from commit e8cac071fb9106cbe235d3ff1f4dd9bfbd6c4cef) --- bgpd/bgp_attr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/bgpd/bgp_attr.c b/bgpd/bgp_attr.c index 698e09db99..6be69bd238 100644 --- a/bgpd/bgp_attr.c +++ b/bgpd/bgp_attr.c @@ -1391,6 +1391,7 @@ bgp_attr_malformed(struct bgp_attr_parser_args *args, uint8_t subcode, */ case BGP_ATTR_ORIGIN: case BGP_ATTR_AS_PATH: + case BGP_ATTR_AS4_PATH: case BGP_ATTR_NEXT_HOP: case BGP_ATTR_MULTI_EXIT_DISC: case BGP_ATTR_LOCAL_PREF: -- 2.39.5