From 21dfc9ed509ff8571feb3bcdae57602574fca5b9 Mon Sep 17 00:00:00 2001 From: Donald Sharp Date: Thu, 31 Aug 2017 13:01:35 -0400 Subject: [PATCH] eigrpd: Clean up some new coverity issues Signed-off-by: Donald Sharp --- eigrpd/eigrp_packet.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/eigrpd/eigrp_packet.c b/eigrpd/eigrp_packet.c index 8a7d4d9587..d2bff74a54 100644 --- a/eigrpd/eigrp_packet.c +++ b/eigrpd/eigrp_packet.c @@ -272,6 +272,7 @@ int eigrp_make_sha256_digest(struct eigrp_interface *ei, struct stream *s, if (!key) { zlog_warn("Interface %s: Expected key value not found in config", ei->ifp->name); + eigrp_authTLV_SHA256_free(auth_TLV); return 0; } @@ -622,8 +623,8 @@ int eigrp_read(struct thread *thread) if (IS_DEBUG_EIGRP_TRANSMIT(0, RECV)) { char src[PREFIX_STRLEN], dst[PREFIX_STRLEN]; - strncpy(src, inet_ntoa(iph->ip_src), PREFIX_STRLEN); - strncpy(dst, inet_ntoa(iph->ip_dst), PREFIX_STRLEN); + strlcpy(src, inet_ntoa(iph->ip_src), sizeof(src)); + strlcpy(dst, inet_ntoa(iph->ip_dst), sizeof(dst)); zlog_debug("Received [%s][%d/%d] length [%u] via [%s] src [%s] dst [%s]", lookup_msg(eigrp_packet_type_str, opcode, NULL), ntohl(eigrph->sequence), ntohl(eigrph->ack), length, -- 2.39.5