From 21a93a5f1b8c3ebd1f0c39a8eabd777d0788e384 Mon Sep 17 00:00:00 2001 From: Satheesh Kumar K Date: Thu, 21 Nov 2019 20:33:42 -0800 Subject: [PATCH] zebra: Fixing Comments in MLAG Read scheduling Events Zebra MLAG is using "t_read" for multiple tasks, such as 1. For opening Communication channel with MLAG 2. In case conncetion fails, same event is used for retries 3. after the connection establishment, same event is used to read the data from MLAG since all these taks will never schedule together, this will not cause any issues. Signed-off-by: Satheesh Kumar K --- zebra/zebra_mlag_private.c | 2 -- zebra/zebra_router.h | 8 +++++++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/zebra/zebra_mlag_private.c b/zebra/zebra_mlag_private.c index 6a31d47055..4df7b6dd11 100644 --- a/zebra/zebra_mlag_private.c +++ b/zebra/zebra_mlag_private.c @@ -166,8 +166,6 @@ static int zebra_mlag_connect(struct thread *thread) /* Reset the Timer-running flag */ zrouter.mlag_info.timer_running = false; - /* Reset, sothat Next task can be scheduled */ - zrouter.mlag_info.t_read = NULL; svr.sun_family = AF_UNIX; #define MLAG_SOCK_NAME "/var/run/clag-zebra.socket" strlcpy(svr.sun_path, MLAG_SOCK_NAME, sizeof(MLAG_SOCK_NAME) + 1); diff --git a/zebra/zebra_router.h b/zebra/zebra_router.h index 437cab5bbd..d8ad8a6864 100644 --- a/zebra/zebra_router.h +++ b/zebra/zebra_router.h @@ -97,8 +97,14 @@ struct zebra_mlag_info { /* MLAG Thread context 'master' */ struct thread_master *th_master; - /* Threads for read/write. */ + /* + * Event for Initial MLAG Connection setup & Data Read + * Read can be performed only after successful connection establishment, + * so no issues. + * + */ struct thread *t_read; + /* Event for MLAG write */ struct thread *t_write; }; -- 2.39.5