From 208c8ec862bd85d8364194097e07b3a7fb362cce Mon Sep 17 00:00:00 2001 From: Donatas Abraitis Date: Thu, 13 Aug 2020 18:42:31 +0300 Subject: [PATCH] bgpd: Dump attributes before returning from bgp_attr_malformed() This would be handy for situations when a notification was sent, but it's absolutely not clear who triggered that. Just in case dumping all attributes under the debug mode would help finding the _bad_ attribute. Signed-off-by: Donatas Abraitis --- bgpd/bgp_attr.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/bgpd/bgp_attr.c b/bgpd/bgp_attr.c index 16de59b72c..28d5f6a231 100644 --- a/bgpd/bgp_attr.c +++ b/bgpd/bgp_attr.c @@ -954,6 +954,7 @@ bgp_attr_malformed(struct bgp_attr_parser_args *args, uint8_t subcode, bgp_size_t length) { struct peer *const peer = args->peer; + struct attr *const attr = args->attr; const uint8_t flags = args->flags; /* startp and length must be special-cased, as whether or not to * send the attribute data with the NOTIFY depends on the error, @@ -961,6 +962,14 @@ bgp_attr_malformed(struct bgp_attr_parser_args *args, uint8_t subcode, */ uint8_t *notify_datap = (length > 0 ? args->startp : NULL); + if (bgp_debug_update(peer, NULL, NULL, 1)) { + char attr_str[BUFSIZ] = {0}; + + bgp_dump_attr(attr, attr_str, BUFSIZ); + + zlog_debug("%s: attributes: %s", __func__, attr_str); + } + /* Only relax error handling for eBGP peers */ if (peer->sort != BGP_PEER_EBGP) { bgp_notify_send_with_data(peer, BGP_NOTIFY_UPDATE_ERR, subcode, -- 2.39.5