From 1dde2fbf7893670c0b44abab261c74f4ef7636ae Mon Sep 17 00:00:00 2001 From: Renato Westphal Date: Mon, 28 May 2018 10:18:37 -0300 Subject: [PATCH] ripd: remove vty configuration lock The vty configuration lock is used to prevent inconsistencies when multiple users are editing the configuration at the same time. The pointer stored in vty->index might become invalid if the associated configuration object is removed by another user in another CLI session. Commands converted to the new northbound model don't use vty->index, but vty->xpath_index and the vty->xpath array. The nb_cli_cfg_change() function uses the VTY_CHECK_XPATH macro to check if the configuration object being edited still exists and returns an error if it doesn't. Now that all ripd commands were converted to the new northbound model, remove the ripd vty lock because it's not necessary anymore. Signed-off-by: Renato Westphal --- ripd/rip_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ripd/rip_main.c b/ripd/rip_main.c index 5db9c4b7e9..4ee5994a9d 100644 --- a/ripd/rip_main.c +++ b/ripd/rip_main.c @@ -165,6 +165,8 @@ int main(int argc, char **argv) } } + vty_config_lockless(); + /* Prepare master thread. */ master = frr_init(); -- 2.39.5