From 162dbe419dfc3d3322b6eb555cfc10f4fa952e6f Mon Sep 17 00:00:00 2001 From: paco Date: Mon, 25 Jun 2018 17:18:17 +0200 Subject: [PATCH] ospfd: null check (Coverity 1399284) Signed-off-by: F. Aragon --- ospfd/ospf_zebra.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/ospfd/ospf_zebra.c b/ospfd/ospf_zebra.c index 141ece9c7a..0a7776cced 100644 --- a/ospfd/ospf_zebra.c +++ b/ospfd/ospf_zebra.c @@ -670,6 +670,16 @@ int ospf_redistribute_set(struct ospf *ospf, int type, unsigned short instance, struct ospf_redist *red; red = ospf_redist_lookup(ospf, type, instance); + + if (red == NULL) { + zlog_err( + "Redistribute[%s][%d]: Lookup failed Type[%d] , Metric[%d]", + ospf_redist_string(type), instance, + metric_type(ospf, type, instance), + metric_value(ospf, type, instance)); + return CMD_WARNING_CONFIG_FAILED; + } + if (ospf_is_type_redistributed(ospf, type, instance)) { if (mtype != red->dmetric.type) { red->dmetric.type = mtype; -- 2.39.5