From 13f0e434430d20065d889163872b5c6dc22d3db9 Mon Sep 17 00:00:00 2001 From: paco Date: Mon, 25 Jun 2018 12:55:53 +0200 Subject: [PATCH] ospfd: OoB access (Coverity 1399304 1399286) Signed-off-by: F. Aragon --- ospfd/ospf_vty.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/ospfd/ospf_vty.c b/ospfd/ospf_vty.c index 7d748419fa..ddf9133ed9 100644 --- a/ospfd/ospf_vty.c +++ b/ospfd/ospf_vty.c @@ -8166,6 +8166,11 @@ DEFUN (ospf_redistribute_instance_source, source = proto_redistnum(AFI_IP, argv[idx_ospf_table]->text); + if (source < 0) { + vty_out(vty, "Unknown instance redistribution\n"); + return CMD_WARNING_CONFIG_FAILED; + } + instance = strtoul(argv[idx_number]->arg, NULL, 10); if ((source == ZEBRA_ROUTE_OSPF) && !ospf->instance) { -- 2.39.5