From 0c5021ada5f61b62ee288b5eca8d9ae678e348b5 Mon Sep 17 00:00:00 2001
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
Date: Tue, 4 Jun 2019 06:35:12 +0200
Subject: [PATCH] followup code cleanup

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
---
 PVE/Network/Network.pm | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/PVE/Network/Network.pm b/PVE/Network/Network.pm
index 27c30b9..a89e302 100644
--- a/PVE/Network/Network.pm
+++ b/PVE/Network/Network.pm
@@ -46,8 +46,7 @@ sub lock_network_config {
     my ($code, $errmsg) = @_;
 
     cfs_lock_file("networks.cfg.new", undef, $code);
-    my $err = $@;
-    if ($err) {
+    if (my $err = $@) {
         $errmsg ? die "$errmsg: $err" : die $err;
     }
 }
@@ -69,15 +68,12 @@ sub complete_network {
 sub status {
 
     my $cmd = ['ifquery', '-a', '-c', '-o','json'];
-    my $result;;
 
-    my $code = sub {
-        my $line = shift;
-	$result .= $line;
-    };
+    my $result = '';
+    my $reader = sub { $result .= shift };
 
     eval {
-	run_command($cmd, outfunc => $code, errfunc => $code);
+	run_command($cmd, outfunc => $reader, errfunc => $reader);
     };
 
     my $resultjson = JSON::decode_json($result);
-- 
2.39.5