]> git.puffer.fish Git - mirror/frr.git/commit
zebra: fix evpn mh bond member proto reinstall 16252/head
authorChirag Shah <chirag@nvidia.com>
Wed, 19 Jun 2024 00:21:49 +0000 (17:21 -0700)
committerChirag Shah <chirag@nvidia.com>
Thu, 20 Jun 2024 16:09:21 +0000 (09:09 -0700)
commite4d843b438ae7cbae89ae47af0754fb1db153c6c
tree26c735131d7513df8e136f927c4483ed5c52181c
parent34a6e223fb2a1ad479aa36d997850924baa137a9
zebra: fix evpn mh bond member proto reinstall

In case of EVPN MH bond, a member port going in
protodown state due to external reason (one case being linkflap),
frr updates the state correctly but upon manually
clearing external reason trigger FRR to reinstate
protodown without any reason code.

Fix is to ensure if the protodown reason was external
and new state is to have protodown 'off' then do no reinstate
protodown.

Ticket: #3947432
Testing:
switch:#ip link show swp1
4: swp1: <NO-CARRIER,BROADCAST,MULTICAST,SLAVE,UP> mtu 9216 qdisc
   pfifo_fast master bond1 state DOWN mode DEFAULT group default qlen
   1000
       link/ether 1c:34:da:2c:aa:68 brd ff:ff:ff:ff:ff:ff protodown on
       protodown_reason <linkflap>

switch:#ip link set swp1 protodown off protodown_reason linkflap off
switch:#ip link show swp1
 4: swp1: <NO-CARRIER,BROADCAST,MULTICAST,SLAVE,UP> mtu 9216 qdisc
    pfifo_fast master bond1 state DOWN mode DEFAULT group default qlen
    1000
        link/ether 1c:34:da:2c:aa:68 brd ff:ff:ff:ff:ff:ff

Signed-off-by: Chirag Shah <chirag@nvidia.com>
zebra/interface.c