]> git.puffer.fish Git - matthieu/frr.git/commit
isisd: Fix memory leaks when the transition of neighbor state from non-UP to DOWN
authorzhou-run <166502045+zhou-run@users.noreply.github.com>
Tue, 9 Apr 2024 13:04:39 +0000 (21:04 +0800)
committerbaozhen (RD) <bao.zhen@h3c.com>
Thu, 23 May 2024 07:47:33 +0000 (15:47 +0800)
commit5009f7539ad6bf496158499917dcf3f7ab760753
tree46506a691bfd8f5b59d35e1b9ace245a03f52345
parentf9b1067bf1d68ab0eeca60b60cf878269753c23f
isisd: Fix memory leaks when the transition of neighbor state from non-UP to DOWN

When receiving a hello packet, if the neighbor state transitions directly from a non-ISIS_ADJ_UP state (such as ISIS_ADJ_INITIALIZING) to ISIS_ADJ_DOWN state, the neighbor entry cannot be deleted. If the neighbor is removed or the neighbor's System ID changes, it may result in memory leakage in the neighbor entry.

Test Scenario:
LAN link between Router A and Router B is established. Router A does not configure neighbor authentication, while Router B is configured with neighbor authentication. When the neighbor entry on Router B ages out, the neighbor state on Router A transitions to INIT. If Router B is then removed, the neighbor state on Router A transitions to DOWN and persists.

Signed-off-by: zhou-run <166502045+zhou-run@users.noreply.github.com>
fix frrbot styling issues found.

fix frrbot styling issues found.

Signed-off-by: zhou-run <166502045+zhou-run@users.noreply.github.com>
isisd/isis_adjacency.c