]>
git.puffer.fish Git - mirror/frr.git/log
Philippe Guibert [Wed, 10 May 2017 17:27:33 +0000 (19:27 +0200)]
bgpd: fixup bgpd: allow VPN next hop to be different AFI than NLRI next
hop for EVPN
In the case of EVPN, add the nexthop attribute.
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
Donald Sharp [Wed, 10 May 2017 00:39:35 +0000 (20:39 -0400)]
Merge remote-tracking branch 'origin/stable/3.0'
Russ White [Tue, 9 May 2017 23:56:47 +0000 (19:56 -0400)]
Merge pull request #486 from LabNConsulting/working/3.0/patch/issue483
bgp rfapi: rfapi shouldn't be called (yet) for BGP VRF instances.
Russ White [Tue, 9 May 2017 23:49:27 +0000 (19:49 -0400)]
Merge pull request #480 from donaldsharp/agentx
Agentx
Russ White [Tue, 9 May 2017 23:48:00 +0000 (19:48 -0400)]
Merge pull request #488 from donaldsharp/sudoers3
*: Remove ability to install frr_sudoers for 3.0
Donald Sharp [Tue, 9 May 2017 20:18:04 +0000 (16:18 -0400)]
*: Remove ability to install frr_sudoers
If the user were to uncomment last line
and allow VTYSH_SHOW to be used as a non-root
account, this would allow arbitrary command completion
inside of vtysh via multiple -c ... -c .... lines
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Donald Sharp [Tue, 9 May 2017 19:45:15 +0000 (15:45 -0400)]
Merge pull request #485 from LabNConsulting/working/3.0/patch-set/missing1
Pick up a couple of patches to master that are needed on 3.0
Lou Berger [Tue, 9 May 2017 18:38:55 +0000 (14:38 -0400)]
bgp rfapi: rfapi shouldn't be called (yet) for BGP VRF instances.
Lou Berger [Sun, 2 Apr 2017 19:34:55 +0000 (15:34 -0400)]
bgpd: restore -S, --skip_runas options
Signed-off-by: Lou Berger <lberger@labn.net>
Lou Berger [Sun, 2 Apr 2017 17:55:58 +0000 (13:55 -0400)]
bgp: fix a couple of instances of bm being used before init'ed
Signed-off-by: Lou Berger <lberger@labn.net>
Donald Sharp [Tue, 9 May 2017 15:55:54 +0000 (11:55 -0400)]
Merge pull request #478 from opensourcerouting/test-extension
tests: allow to use exit_cleanly as test method
David Lamparter [Tue, 9 May 2017 15:54:46 +0000 (17:54 +0200)]
Merge pull request #469 from qlyoung/fix-list-perm-3.0
lib: fix 'list permutations' (3.0)
Lou Berger [Tue, 9 May 2017 15:54:33 +0000 (11:54 -0400)]
Merge pull request #454 from dwalton76/hide-router-bgp-peer-ipv4-unicast-commands
bgpd: hide "router bgp" commands also under "address-family ipv4 unic…
David Lamparter [Tue, 9 May 2017 15:54:22 +0000 (17:54 +0200)]
Merge pull request #468 from qlyoung/fix-list-perm
lib: fix 'list permutations'
Jafar Al-Gharaibeh [Tue, 9 May 2017 15:50:56 +0000 (10:50 -0500)]
Merge pull request #435 from chiragshah6/pim_dev
pimd: Introduce show command for protocol counters
Donald Sharp [Tue, 9 May 2017 14:16:38 +0000 (10:16 -0400)]
debian: Mark FRR as conflicting with Quagga
FRR when compiled with this debian packaging will cause
some issue with the system to work properly due to the
sudoers file conflicts.
So to prevent some level of stupidity, mark them as
conflicting.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Donald Sharp [Fri, 5 May 2017 19:28:38 +0000 (15:28 -0400)]
*: Allow agentx to be displayed as part of vtysh
Modify code so that that vtysh can now accept the
agentx command for snmp support
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Donald Sharp [Mon, 8 May 2017 20:51:21 +0000 (16:51 -0400)]
Merge remote-tracking branch 'origin/stable/3.0'
Jafar Al-Gharaibeh [Mon, 8 May 2017 20:01:04 +0000 (15:01 -0500)]
Merge pull request #475 from chiragshah6/pim_dev_3_0
Pim related defect fixes
Jafar Al-Gharaibeh [Mon, 8 May 2017 20:00:09 +0000 (15:00 -0500)]
Merge pull request #464 from donaldsharp/datacenter
Datacenter
Donald Sharp [Mon, 8 May 2017 18:44:25 +0000 (14:44 -0400)]
Merge remote-tracking branch 'origin/master' into datacenter
Donald Sharp [Mon, 8 May 2017 17:40:14 +0000 (13:40 -0400)]
Merge pull request #477 from opensourcerouting/gitignore
*: ignore libtool library anotation files
Christian Franke [Mon, 8 May 2017 15:24:34 +0000 (17:24 +0200)]
*: ignore libtool library anotation files
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
Christian Franke [Mon, 8 May 2017 15:24:30 +0000 (17:24 +0200)]
tests: allow to use exit_cleanly as test method
TestMultiOut can now also just check for clean exit
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
Martin Winter [Mon, 8 May 2017 14:32:42 +0000 (16:32 +0200)]
Merge pull request #449 from dwalton76/valgrind-enable
Add valgrind_enable option to /etc/frr/debian.conf
Daniel Walton [Mon, 8 May 2017 13:28:07 +0000 (13:28 +0000)]
Added config option for valgrind executable
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
Russ White [Sun, 7 May 2017 23:49:26 +0000 (19:49 -0400)]
Merge pull request #476 from qlyoung/abort-select-fd
lib: abort if fd >= FD_SETSIZE and using select
Russ White [Sun, 7 May 2017 23:48:33 +0000 (19:48 -0400)]
Merge pull request #409 from donaldsharp/EIGRP
Eigrp
Donald Sharp [Sun, 7 May 2017 12:15:51 +0000 (08:15 -0400)]
doc: Fix spelling mistake.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Quentin Young [Sun, 7 May 2017 04:42:07 +0000 (04:42 +0000)]
lib: abort if fd >= FD_SETSIZE and using select
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
Donald Sharp [Sun, 7 May 2017 00:55:15 +0000 (20:55 -0400)]
Merge pull request #474 from opensourcerouting/isis-mt-additions
IS-IS additions
Chirag Shah [Fri, 21 Apr 2017 22:08:03 +0000 (15:08 -0700)]
pimd: Fix WG/SGRpt & WG J/P processing
During processing of Join/Prune,
for a S,G entry, current state is SGRpt, when only *,G is
received, need to clear SGRpt and add/inherit the *,G OIF to S,G so
it can forward traffic to downstream where *,G is received.
Upon receiving SGRpt prune remove the inherited *,G OIF.
From, downstream router received *,G Prune along with SGRpt
prune. Avoid sending *,G and SGRpt Prune together.
Reset upstream_del reset ifchannel to NULL.
Testing Done:
Run failed smoke test of sending data packets, trigger SPT switchover,
*,G path received SGRpt later data traffic stopped S,G ages out from LHR, sends only
*,G join to upstream, verified S,G entry inherit the OIF.
Upon receiving SGRpt deletes inherited oif and retains in SGRpt state.
Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
Chirag Shah [Wed, 26 Apr 2017 01:56:00 +0000 (18:56 -0700)]
pimd: replay IGMP static group upon if creation
Upon static IGMP configured port down igmp source info is destroyed.
Upon port up or quagga restart (if addr add) register IGMP sock with
port, source, group.
Testing Done:
Configure IGMPv3 Report on Host swpx, ifdown/ifup swpx,
verify ip mroute containng IGMP mroute
tor-1# show ip mroute
Source Group Proto Input Output TTL Uptime
30.1.1.1 225.1.1.21 IGMP swp2 swp3 1 00:00:05
Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
Chirag Shah [Thu, 4 May 2017 01:56:44 +0000 (18:56 -0700)]
pimd: fix pimd crash when pim interface disabled
Upon pim enabled disabled, current upstreams entries rpf update callback,
needs to check if old rpf is still pim enabled otherwise do not trigger
prune towards old rpf.
Testing Done:
Verified by disabling pim enabled rpf interface and
crash is not observed upon disabling pim on rpf interface.
Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
Chirag Shah [Mon, 10 Apr 2017 20:27:56 +0000 (13:27 -0700)]
pimd: fix pim ecmp rebalance config write
ip pim ecmp and ip pim ecmp rebalance configuration CLIs were
not adding to Quagga.confg or running configuration.
Added both the configuration write in Config write handler.
Testing Done: Execute configuration cli and verified running config
and Quagga.conf file containing both configuration.
03# show running-config
Building configuration...
Current configuration:
!
ip multicast-routing
ip pim rp 6.0.0.9 230.0.0.0/16
ip pim join-prune-interval 61
ip pim ecmp
ip pim ecmp rebalance
!
Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
Chirag Shah [Thu, 27 Apr 2017 18:01:32 +0000 (11:01 -0700)]
pimd: fix channel_oil and upstream RPF in sync
During PIM Neighbor change/UP event, pim_scan_oil api
scans all channel oil to see any rpf impacted. Instead of
passing current upstream's RPF it passes current RPF as 0 and
does query to rib for nexhtop (without ECMP/Rebalance). This creates
inconsist RPF between Upstream and Channel oil.
In Channel Oil keep backward pointer to upstream DB and fetch up's
RPF and passed to channel_oil scan.
Decrement channel_oil ref_count in upstream_del when decrementing
up ref_count and it is not the last.
Created ECMP based FIB lookup API.
Testing Done:
Performed following testing on tester setup:
5 x LHR, 4 x MSDP Spines, 6 Sources each sending to 1023 groups from one of the spines.
Total send rate 8Mpps.
Test that caused problems was to reboot every device at the same time.
After fix performed 5 iterations of reboot devices and show no sign of the problem.
Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
Russ White [Sat, 6 May 2017 22:33:38 +0000 (18:33 -0400)]
Merge pull request #462 from donaldsharp/poll_3.0
lib: Rename HAVE_POLL to prevent conflicting #defines
Russ White [Sat, 6 May 2017 22:24:36 +0000 (18:24 -0400)]
Merge pull request #470 from dslicenc/cm16223
bgpd: resolve crash displaying bgp vrf routing info
Donald Sharp [Sat, 6 May 2017 18:12:54 +0000 (14:12 -0400)]
eigrpd: Basic Documentation
Add some basic documentation for the EIGRP protocol.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Christian Franke [Sat, 6 May 2017 13:50:50 +0000 (15:50 +0200)]
isisd: use MT to only advertise usable links
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
Christian Franke [Sat, 6 May 2017 13:50:47 +0000 (15:50 +0200)]
isisd: support unnumbered operation
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
Christian Franke [Sat, 6 May 2017 13:50:45 +0000 (15:50 +0200)]
isisd: show topology information for adjacencies
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
Christian Franke [Sat, 6 May 2017 13:50:41 +0000 (15:50 +0200)]
isisd: ensure that MT is only used with wide metrics
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
Christian Franke [Sat, 6 May 2017 13:50:37 +0000 (15:50 +0200)]
isisd: fix initialization of ES vertizes
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
Martin Winter [Sat, 6 May 2017 01:03:45 +0000 (18:03 -0700)]
Merge pull request #472 from qlyoung/rfapi-correct-types
rfapi void * -> struct thread *
Martin Winter [Sat, 6 May 2017 00:51:18 +0000 (17:51 -0700)]
Merge pull request #447 from donaldsharp/moobot
doc: Fix systemd build instructions
Quentin Young [Fri, 5 May 2017 21:08:44 +0000 (21:08 +0000)]
bgpd: use correct type for rfapi thread pointer
Pointer to void always points at the same thing so make it the type of
the thing that it points at
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
Lou Berger [Fri, 5 May 2017 19:54:11 +0000 (15:54 -0400)]
Merge pull request #466 from dslicenc/aggregate
bgpd: resolve crash in workqueue processing due to invalid safi
Don Slice [Fri, 5 May 2017 13:53:49 +0000 (06:53 -0700)]
bgpd: resolve crash displaying bgp vrf routing info
Problem uncovered with crash when entering the command "show ip bgp
vrf vrf1001 0.0.0.0". The crash was caused by a mistake incrementing
the index value in the vrf/view case. Manual testing completed and
failing test case now passes successfully.
Ticket: CM-16223
Signed-off-by: Don Slice <dslice@cumulusnetworks.com>
Reviewed By: Donald Sharp <sharpd@cumulusnetworks.com>
Quentin Young [Thu, 4 May 2017 22:46:46 +0000 (22:46 +0000)]
lib: fix 'list permutations'
Cyclic graphs ftw
Also remove graph pretty printer from permutations.c 'cause it's not
really needed anymore
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
Quentin Young [Thu, 4 May 2017 22:46:46 +0000 (22:46 +0000)]
lib: fix 'list permutations'
Cyclic graphs ftw
Also remove graph pretty printer from permutations.c 'cause it's not
really needed anymore
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
Donald Sharp [Thu, 4 May 2017 20:27:12 +0000 (16:27 -0400)]
Merge pull request #465 from opensourcerouting/cli-fuzzer-fixes
*: fix a bunch of segfaults detected by a CLI fuzzer
Renato Westphal [Thu, 4 May 2017 18:14:49 +0000 (15:14 -0300)]
Merge pull request #452 from hwchiu/fix_ldpd
Fix the error message when execute ldpd with --enable-tcp-zebra
Jafar Al-Gharaibeh [Thu, 4 May 2017 18:09:44 +0000 (13:09 -0500)]
Merge pull request #463 from donaldsharp/pim_stable_3.0
Pim stable 3.0
Don Slice [Wed, 3 May 2017 13:15:20 +0000 (06:15 -0700)]
bgpd: resolve crash in workqueue processing due to invalid safi
Crash uncovered when workqueue item was pulled with safi set to 7
(SAFI_LABELED_UNICAST) without labled-unicast being configured.
Also fixed minor issue removing aggregate-address command due to bad
index.
Ticket: CM-16169
Signed-off-by: Don Slice <dslice@cumulusnetworks.com>
Reviewed-by: Donald Sharp <sharpd@cumulusnetworks.com>
Renato Westphal [Thu, 4 May 2017 02:49:50 +0000 (23:49 -0300)]
*: fix a bunch of segfaults detected by a CLI fuzzer
This patch fixes the following segfaults:
zebra aborted: vtysh -c "show ipv6 mroute"
zebra aborted: vtysh -c "configure terminal" -c "debug zebra kernel msgdump"
zebra aborted: vtysh -c "configure terminal" -c "interface eth99" -c "link-params" -c "no packet-loss"
zebra aborted: vtysh -c "configure terminal" -c "interface eth99" -c "link-params" -c "no metric"
zebra aborted: vtysh -c "configure terminal" -c "interface eth99" -c "link-params" -c "no ava-bw"
zebra aborted: vtysh -c "configure terminal" -c "interface eth99" -c "link-params" -c "no res-bw"
zebra aborted: vtysh -c "configure terminal" -c "interface eth99" -c "link-params" -c "no use-bw"
ospfd aborted: vtysh -c "configure terminal" -c "router ospf" -c "area 1.1.1.1 nssa"
ospfd aborted: vtysh -c "configure terminal" -c "router ospf" -c "area
4294967295 nssa"
pimd aborted: vtysh -c "show ip msdp sa 1.1.1.1"
pimd aborted: vtysh -c "configure terminal" -c "ip ssmpingd"
pimd aborted: vtysh -c "configure terminal" -c "no ip ssmpingd"
pimd aborted: vtysh -c "configure terminal" -c "no ip msdp mesh-group WORD source"
pimd aborted: vtysh -c "configure terminal" -c "interface eth99" -c "ip pim hello 180"
bgpd aborted: vtysh -c "show bgp l2vpn evpn rd 1:1"
bgpd aborted: vtysh -c "clear vnc nve un *"
bgpd aborted: vtysh -c "clear vnc nve un 1.1.1.1"
bgpd aborted: vtysh -c "clear vnc nve un 2001:db8::1"
bgpd aborted: vtysh -c "add vnc mac 11:11:11:11:11:11 virtual-network-identifier
4294967295 vn 1.1.1.1 un 1.1.1.1 lifetime
4294967295 "
bgpd aborted: vtysh -c "add vnc mac 11:11:11:11:11:11 virtual-network-identifier
4294967295 vn 1.1.1.1 un 1.1.1.1 cost 255 lifetime
4294967295 "
bgpd aborted: vtysh -c "add vnc mac 11:11:11:11:11:11 virtual-network-identifier
4294967295 vn 1.1.1.1 un 1.1.1.1 cost 255"
bgpd aborted: vtysh -c "add vnc mac 11:11:11:11:11:11 virtual-network-identifier
4294967295 vn 1.1.1.1 un 1.1.1.1"
bgpd aborted: vtysh -c "add vnc mac 11:11:11:11:11:11 virtual-network-identifier
4294967295 vn 1.1.1.1 un 2001:db8::1 lifetime
4294967295 "
bgpd aborted: vtysh -c "add vnc mac 11:11:11:11:11:11 virtual-network-identifier
4294967295 vn 1.1.1.1 un 2001:db8::1 cost 255 lifetime
4294967295 "
bgpd aborted: vtysh -c "add vnc mac 11:11:11:11:11:11 virtual-network-identifier
4294967295 vn 1.1.1.1 un 2001:db8::1 cost 255"
bgpd aborted: vtysh -c "add vnc mac 11:11:11:11:11:11 virtual-network-identifier
4294967295 vn 1.1.1.1 un 2001:db8::1"
bgpd aborted: vtysh -c "add vnc mac 11:11:11:11:11:11 virtual-network-identifier
4294967295 vn 2001:db8::1 un 1.1.1.1 lifetime
4294967295 "
bgpd aborted: vtysh -c "add vnc mac 11:11:11:11:11:11 virtual-network-identifier
4294967295 vn 2001:db8::1 un 1.1.1.1 cost 255 lifetime
4294967295 "
bgpd aborted: vtysh -c "add vnc mac 11:11:11:11:11:11 virtual-network-identifier
4294967295 vn 2001:db8::1 un 1.1.1.1 cost 255"
bgpd aborted: vtysh -c "add vnc mac 11:11:11:11:11:11 virtual-network-identifier
4294967295 vn 2001:db8::1 un 1.1.1.1"
bgpd aborted: vtysh -c "add vnc mac 11:11:11:11:11:11 virtual-network-identifier
4294967295 vn 2001:db8::1 un 2001:db8::1 lifetime
4294967295 "
bgpd aborted: vtysh -c "add vnc mac 11:11:11:11:11:11 virtual-network-identifier
4294967295 vn 2001:db8::1 un 2001:db8::1 cost 255 lifetime
4294967295 "
bgpd aborted: vtysh -c "add vnc mac 11:11:11:11:11:11 virtual-network-identifier
4294967295 vn 2001:db8::1 un 2001:db8::1 cost 255"
bgpd aborted: vtysh -c "add vnc mac 11:11:11:11:11:11 virtual-network-identifier
4294967295 vn 2001:db8::1 un 2001:db8::1"
bgpd aborted: vtysh -c "configure terminal" -c "router bgp 1" -c "no vnc export bgp ipv4 prefix-list NAME"
bgpd aborted: vtysh -c "configure terminal" -c "router bgp 1" -c "no vnc export bgp ipv6 prefix-list NAME"
bgpd aborted: vtysh -c "configure terminal" -c "router bgp 1" -c "no vnc export bgp route-map NAME"
bgpd aborted: vtysh -c "configure terminal" -c "router bgp 1" -c "no vnc export zebra ipv4 prefix-list NAME"
bgpd aborted: vtysh -c "configure terminal" -c "router bgp 1" -c "no vnc export zebra ipv6 prefix-list NAME"
bgpd aborted: vtysh -c "configure terminal" -c "router bgp 1" -c "no vnc export zebra route-map NAME"
bgpd aborted: vtysh -c "configure terminal" -c "route-map RMAP permit 1" -c "no set ipv6 vpn next-hop"
bgpd aborted: vtysh -c "configure terminal" -c "route-map RMAP permit 1" -c "set vpnv4 next-hop"
bgpd aborted: vtysh -c "configure terminal" -c "route-map RMAP permit 1" -c "set vpnv6 next-hop"
bgpd aborted: vtysh -c "configure terminal" -c "router bgp" -c "address-family ipv6 vpn" -c "network 2001:db8::1/128 rd 1:1 tag WORD"
bgpd aborted: vtysh -c "configure terminal" -c "router bgp" -c "address-family vpnv6 unicast" -c "network 2001:db8::1/128 rd 1:1 tag WORD"
bgpd aborted: vtysh -c "configure terminal" -c "router bgp" -c "no neighbor WORD shutdown message MSG..."
bgpd aborted: vtysh -c "configure terminal" -c "router bgp" -c "neighbor WORD shutdown message MSG..."
More to come later.
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
Donald Sharp [Thu, 4 May 2017 17:35:25 +0000 (13:35 -0400)]
Merge remote-tracking branch 'origin/stable/3.0'
Renato Westphal [Thu, 4 May 2017 17:33:43 +0000 (14:33 -0300)]
Merge pull request #450 from donaldsharp/afi_safi3
Afi safi3
Renato Westphal [Thu, 4 May 2017 17:28:47 +0000 (14:28 -0300)]
Merge pull request #445 from donaldsharp/robot
Robot
Daniel Walton [Thu, 4 May 2017 17:06:13 +0000 (17:06 +0000)]
bgpd: hide "router bgp" commands also under "address-family ipv4 unicast"
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
Updated the docs and sample configs
Donald Sharp [Thu, 4 May 2017 16:45:01 +0000 (12:45 -0400)]
*: Rename debian.conf -> daemons.conf
The debian.conf file is to specific of a name towards
debian distributions. Rename to be daemons.conf
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Donald Sharp [Thu, 4 May 2017 16:22:50 +0000 (12:22 -0400)]
redhat: Remove references to cumulus directory
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Donald Sharp [Thu, 4 May 2017 16:20:29 +0000 (12:20 -0400)]
*: Remove cumulus Directory
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Donald Sharp [Thu, 4 May 2017 16:11:03 +0000 (12:11 -0400)]
debian: Remove reference of cumulus directory
Use the tools/etc... directory for packaging now
not the cumulus/etc since it is going away
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Donald Sharp [Thu, 4 May 2017 16:10:18 +0000 (12:10 -0400)]
tools: Proper file name is frr.conf
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Donald Sharp [Thu, 4 May 2017 16:09:22 +0000 (12:09 -0400)]
*: Move etc/frr into tools
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Donald Sharp [Thu, 4 May 2017 16:07:45 +0000 (12:07 -0400)]
*: Move default/frr into tools directory
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Donald Sharp [Thu, 4 May 2017 16:06:11 +0000 (12:06 -0400)]
*: Move sudoers file into tools
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Donald Sharp [Thu, 4 May 2017 15:58:36 +0000 (11:58 -0400)]
*: Move ssd from cumulus to tools directory
As discussed on the mailing list, the cumulus directory should
be going away. This commit moves the ssd from cumulus to tools
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Donald Sharp [Thu, 4 May 2017 15:45:30 +0000 (11:45 -0400)]
doc: Update Documentation to let compilers know about new option
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Donald Sharp [Thu, 4 May 2017 15:26:22 +0000 (11:26 -0400)]
*: Add --enable-datacenter to turn on datacenter defaults
Compile in DataCenter Defaults if --enable-datacenter
is configured instead of --enable-cumulus
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Donald Sharp [Tue, 25 Apr 2017 14:00:39 +0000 (10:00 -0400)]
pimd: Note when a S,G stream should be a FHR as well
When we have a S,G being created, that it might
also be a FHR router as well. This happens
when the FHR is in the path of the RP->LHR
for when it builds it's SPT tree for the S,G.
Ticket: CM-16056, CM-15836
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Donald Sharp [Thu, 20 Apr 2017 20:11:58 +0000 (16:11 -0400)]
pimd: Only compare the actual IIF of the *,G to S,G
Now that pim has the ability to use ecmp, the Group
path to the RP, may be different than what is choosen
for the *,G IIF. As such when we are making the
spt switchover decision, compare the S,G IIF to the
*,G IIF.
Ticket: CM-15870
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Donald Sharp [Thu, 4 May 2017 14:24:25 +0000 (10:24 -0400)]
lib: Rename HAVE_POLL to prevent conflicting #defines
Rename HAVE_POLL to HAVE_POLL_CALL, when compiling with
snmp and poll enabled this was causing issues.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Donald Sharp [Wed, 3 May 2017 18:39:21 +0000 (14:39 -0400)]
ospf6d: Allow some route-map commands to work
The generic callbacks need to be enabled in order
for some route-map commands to properly work.
I've tried to match up to what is programmed to work
within ospfv3.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Donald Sharp [Wed, 3 May 2017 18:33:28 +0000 (14:33 -0400)]
ospf6d: Fix redistribution debug knowledge
When redistributing into ospfv3 specify that the
route is add or delete correctly.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Daniel Walton [Wed, 3 May 2017 16:45:14 +0000 (16:45 +0000)]
bgpd: hide "router bgp" commands also under "address-family ipv4 unicast"
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
Reviewed-by: Quentin Young <qlyoung@cumulusnetworks.com>
Jafar Al-Gharaibeh [Wed, 3 May 2017 15:04:59 +0000 (10:04 -0500)]
Merge pull request #451 from opensourcerouting/ospfd-fix-cmdstr
ospfd: fix small problem in the redistribute command
Donald Sharp [Wed, 3 May 2017 14:24:04 +0000 (10:24 -0400)]
vtysh: Fix _ instead of - usage for labeled_unicast
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Donald Sharp [Wed, 3 May 2017 13:35:06 +0000 (09:35 -0400)]
doc: Add systemd dev package to doc
Add the systemd dev package to the list of items to install
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Hung-Weic Chiu [Wed, 3 May 2017 13:27:29 +0000 (13:27 +0000)]
Fix the error message when execute ldpd with --enable-tcp-zebra
- If we use the option "--enable-tcp-zebra " to configure, the zclient will use the tcp socket instead of unix domain socket.
- The ldpd will pass the "-z path" options to `frr_opt` and that will execute zclient_serv_path_set to check the domain socket.
- Add the define to ldpd, if the "HAVE_TCP_ZEBRA" has been define, don't pass the "-z path" to `frr_opt`.
Signed-off-by: Hung-Weic Chiu <sppsorrg@gmail.com>
Daniel Walton [Wed, 3 May 2017 13:18:20 +0000 (13:18 +0000)]
Add valgrind_enable option to /etc/frr/debian.conf
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
This allows you to start all daemons via valgrind so you can catch
memory leaks, etc.
Donald Sharp [Wed, 3 May 2017 13:13:12 +0000 (09:13 -0400)]
bgpd: Fix crashes with '[no] neighbor ... shutdown ..' command
This fixes two crashes:
1) When we enter a 'neighbor shutdown..' command for a peer
group or interface based peer we were not properly looking
up the peer.
2) When we we enter 'no neighbor shutdown..' command for
a peer group or interface based peer we were not properly
lookup up the peer.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Renato Westphal [Wed, 3 May 2017 13:03:14 +0000 (10:03 -0300)]
ospfd: fix small problem in the redistribute command
The use of {<>} is unnecessary and not correct.
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
Donald Sharp [Wed, 3 May 2017 12:11:38 +0000 (08:11 -0400)]
zebra: Fix leaked memory in label manager code
When we fail to properly setup we can leak some memory.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Donald Sharp [Wed, 3 May 2017 11:06:20 +0000 (07:06 -0400)]
doc: Fix systemd build instructions
Fix the build/install instructions for Ubuntu 16.04 and
systemd.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Donald Sharp [Wed, 3 May 2017 02:14:24 +0000 (22:14 -0400)]
bgpd: Fix crash associated with aggregate command
The cli rework created this issue
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Donald Sharp [Wed, 3 May 2017 01:48:46 +0000 (21:48 -0400)]
bgpd: When receiving a route set the label to invalid
When we are receiving a route the attr->extra->label_index
is being set to 0. This should be BGP_INVALID_LABEL_INDEX
instead since we cannot rely on 0 to be correct for labels.
I believe that there are probably other spots that need this
type of fix, but I will let testing snuggle-bump them out.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Donald Sharp [Tue, 2 May 2017 14:20:10 +0000 (10:20 -0400)]
bgpd: Fix 'show bgp ... summary json' to have empty {}
When we have no output for a json command we should have
an empty {} displayed.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Donald Sharp [Tue, 2 May 2017 23:49:13 +0000 (19:49 -0400)]
Merge pull request #442 from Jafaral/pim-hello-fix
Fix: Off by one error, correct index for hold timer
Jafar Al-Gharaibeh [Tue, 2 May 2017 22:23:34 +0000 (17:23 -0500)]
Fix: Off by one error, correct index for hold timer
Signed-off-by: Jafar Al-Gharaibeh <jafar@atcorp.com>
Donald Sharp [Tue, 2 May 2017 19:52:09 +0000 (15:52 -0400)]
Merge remote-tracking branch 'origin/stable/3.0'
Hung-Wei Chiu [Thu, 27 Apr 2017 15:30:56 +0000 (23:30 +0800)]
update doc of ubuntu 12.04
1. modify the prefix to /usr (which is hard-code in /etc/init.d/frr)
2. install init.d related files.
Hung-Wei Chiu [Thu, 27 Apr 2017 15:14:23 +0000 (23:14 +0800)]
Update 14.04 docs to support init.d service
1. Configure the prefix to /usr (frr script hard-code those path in /etc/init.d/frr)
2. Install the service file to /etc/init.d
Jafar Al-Gharaibeh [Tue, 2 May 2017 19:20:30 +0000 (14:20 -0500)]
Merge pull request #440 from donaldsharp/afi_safi3
Afi safi3
Donald Sharp [Tue, 2 May 2017 19:11:46 +0000 (15:11 -0400)]
Merge remote-tracking branch 'origin/stable/2.0'
Donald Sharp [Tue, 2 May 2017 18:31:55 +0000 (14:31 -0400)]
Merge pull request #439 from Jafaral/pim_rpgrp-fix
Fix: reverse logic of when to pass the supplied group address
Donald Sharp [Tue, 2 May 2017 18:20:43 +0000 (14:20 -0400)]
Merge pull request #438 from hwchiu/fix_nhrpd_privs
Fix the error when execute nhrpd
Donald Sharp [Tue, 2 May 2017 17:55:02 +0000 (13:55 -0400)]
pimd: Fix cli uplift mistakes
When we uplifted the cli from old -> new, I did not properly
handle the switch from <1-3> to (1-3) for number ranges.
Also fix some minor variable renaming that happened?
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Donald Sharp [Tue, 2 May 2017 13:47:16 +0000 (09:47 -0400)]
ospfd: Fix a variant of the ospf redistribute command
Fix 'redistribute (ospf|table) ....' command
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>