bgpd: fix logging from rpki_create_socket()

Fix the following crash when logging from rpki_create_socket():

> #0  raise (sig=<optimized out>) at ../sysdeps/unix/sysv/linux/raise.c:50
> #1  0x00007f6e21723798 in core_handler (signo=6, siginfo=0x7f6e1e502ef0, context=0x7f6e1e502dc0) at lib/sigevent.c:248
> #2  <signal handler called>
> #3  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
> #4  0x00007f6e2144e537 in __GI_abort () at abort.c:79
> #5  0x00007f6e2176348e in _zlog_assert_failed (xref=0x7f6e2180c920 <_xref.16>, extra=0x0) at lib/zlog.c:670
> #6  0x00007f6e216b1eda in rcu_read_lock () at lib/frrcu.c:294
> #7  0x00007f6e21762da8 in vzlog_notls (xref=0x0, prio=2, fmt=0x7f6e217afe50 "%s:%d: %s(): assertion (%s) failed", ap=0x7f6e1e504248) at lib/zlog.c:425
> #8  0x00007f6e217632fb in vzlogx (xref=0x0, prio=2, fmt=0x7f6e217afe50 "%s:%d: %s(): assertion (%s) failed", ap=0x7f6e1e504248) at lib/zlog.c:627
> #9  0x00007f6e217621f5 in zlog (prio=2, fmt=0x7f6e217afe50 "%s:%d: %s(): assertion (%s) failed") at lib/zlog.h:73
> #10 0x00007f6e21763596 in _zlog_assert_failed (xref=0x7f6e2180c920 <_xref.16>, extra=0x0) at lib/zlog.c:687
> #11 0x00007f6e216b1eda in rcu_read_lock () at lib/frrcu.c:294
> #12 0x00007f6e21762da8 in vzlog_notls (xref=0x7f6e21a50040 <_xref.68>, prio=4, fmt=0x7f6e21a4999f "getaddrinfo: debug", ap=0x7f6e1e504878) at lib/zlog.c:425
> #13 0x00007f6e217632fb in vzlogx (xref=0x7f6e21a50040 <_xref.68>, prio=4, fmt=0x7f6e21a4999f "getaddrinfo: debug", ap=0x7f6e1e504878) at lib/zlog.c:627
> #14 0x00007f6e21a3f774 in zlog_ref (xref=0x7f6e21a50040 <_xref.68>, fmt=0x7f6e21a4999f "getaddrinfo: debug") at ./lib/zlog.h:84
> #15 0x00007f6e21a451b2 in rpki_create_socket (_cache=0x55729149cc30) at bgpd/bgp_rpki.c:1337
> #16 0x00007f6e2120e7b7 in tr_tcp_open (tr_socket=0x5572914d1520) at rtrlib/rtrlib/transport/tcp/tcp_transport.c:111
> #17 0x00007f6e2120e212 in tr_open (socket=0x5572914b5e00) at rtrlib/rtrlib/transport/transport.c:16
> #18 0x00007f6e2120faa2 in rtr_fsm_start (rtr_socket=0x557290e17180) at rtrlib/rtrlib/rtr/rtr.c:130
> #19 0x00007f6e218b7ea7 in start_thread (arg=<optimized out>) at pthread_create.c:477
> #20 0x00007f6e21527a2f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

rpki_create_socket() is a hook function called from the rtrlib library.
The issue arises because rtrlib initiates its own separate pthread in which
it runs the hook, which does not establish an FRR RCU context. Consequently,
this leads to failures in the logging mechanism that relies on RCU.

Initialize a new FRR pthread context from the rtrlib pthread with a
valid RCU context to allow logging from the rpki_create_socket() and
dependent functions.

Link: https://github.com/FRRouting/frr/issues/15260
Fixes: a951752d4a ("bgpd: create cache server socket in vrf")
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>

lib: add ability to log from external pthread

External libraries can re-enter the FRR code through a hook function. A
crash occurs when logging from this hook function if the library has
initiated a new pthread, as the FRR RCU context is not initialized for
this thread.

Add frr_pthread_non_controlled_startup() function to initialize a valid
RCU context within a FRR pthread context, originating from an external
pthread.

Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>

Merge pull request #15275 from opensourcerouting/fix/one_more_memory_optimization_attr_struct

bgpd: One more attr struct memory optimization

Merge pull request #15276 from mjstapp/port_registry

*: create a single registry of daemons' default port values

Merge pull request #15272 from LabNConsulting/chopps/mgmtd-notif-test

tests: add mgmtd backend notification test

Merge pull request #15264 from opensourcerouting/fix/memory_optimization

bgpd: Optimize memory for rd_ip struct

Merge pull request #15270 from LabNConsulting/chopps/fix-rpm-pkg

redhat: add option to include mgmtd_testc test client

Merge pull request #15266 from donaldsharp/packable

2 memory optimizations

*: create a single registry of daemons' default port values

Create a single registry of default port values that daemons
are using. Most of these are vty ports, but there are some
others for features like ospfapi and zebra FPM.

Signed-off-by: Mark Stapp <mjs@labn.net>

bgpd: One more attr struct memory optimization

```
struct attr {
struct aspath *            aspath;               /*     0     8 */
struct community *         community;            /*     8     8 */
long unsigned int          refcnt;               /*    16     8 */
_uint64_t                  flag;                 /*    24     8 */
struct in_addr             nexthop;              /*    32     4 */
uint32_t                   med;                  /*    36     4 */
uint32_t                   local_pref;           /*    40     4 */
ifindex_t                  nh_ifindex;           /*    44     4 */
uint8_t                    nh_flags;             /*    48     1 */
uint8_t                    origin;               /*    49     1 */
uint8_t                    es_flags;             /*    50     1 */
uint8_t                    router_flag;          /*    51     1 */
uint8_t                    distance;             /*    52     1 */
uint8_t                    df_alg;               /*    53     1 */
uint16_t                   df_pref;              /*    54     2 */
enum pta_type              pmsi_tnl_type;        /*    56     4 */
uint32_t                   rmap_change_flags;    /*    60     4 */
/* --- cacheline 1 boundary (64 bytes) --- */
struct in6_addr            mp_nexthop_global;    /*    64    16 */
struct in6_addr            mp_nexthop_local;     /*    80    16 */
ifindex_t                  nh_lla_ifindex;       /*    96     4 */
mpls_label_t               label;                /*   100     4 */
struct ecommunity *        ecommunity;           /*   104     8 */
struct ecommunity *        ipv6_ecommunity;      /*   112     8 */
struct lcommunity *        lcommunity;           /*   120     8 */
/* --- cacheline 2 boundary (128 bytes) --- */
struct cluster_list *      cluster1;             /*   128     8 */
struct transit *           transit;              /*   136     8 */
struct in_addr             mp_nexthop_global_in; /*   144     4 */
struct in_addr             aggregator_addr;      /*   148     4 */
struct in_addr             originator_id;        /*   152     4 */
uint32_t                   weight;               /*   156     4 */
as_t                       aggregator_as;        /*   160     4 */
uint8_t                    mp_nexthop_len;       /*   164     1 */
uint8_t                    mp_nexthop_prefer_global; /*   165     1 */
uint8_t                    sticky;               /*   166     1 */
uint8_t                    default_gw;           /*   167     1 */
route_tag_t                tag;                  /*   168     4 */
uint32_t                   label_index;          /*   172     4 */
struct bgp_attr_srv6_vpn * srv6_vpn;             /*   176     8 */
struct bgp_attr_srv6_l3vpn * srv6_l3vpn;         /*   184     8 */
/* --- cacheline 3 boundary (192 bytes) --- */
struct bgp_attr_encap_subtlv * encap_subtlvs;    /*   192     8 */
struct bgp_attr_encap_subtlv * vnc_subtlvs;      /*   200     8 */
struct bgp_route_evpn      evpn_overlay;         /*   208    36 */
uint32_t                   mm_seqnum;            /*   244     4 */
uint32_t                   mm_sync_seqnum;       /*   248     4 */
struct ethaddr             rmac;                 /*   252     6 */
/* --- cacheline 4 boundary (256 bytes) was 2 bytes ago --- */
uint16_t                   encap_tunneltype;     /*   258     2 */
uint32_t                   rmap_table_id;        /*   260     4 */
uint32_t                   link_bw;              /*   264     4 */
esi_t                      esi;                  /*   268    10 */

/* XXX 2 bytes hole, try to pack */

uint32_t                   srte_color;           /*   280     4 */
enum nexthop_types_t       nh_type;              /*   284     4 */
enum blackhole_type        bh_type;              /*   288     4 */
uint32_t                   otc;                  /*   292     4 */
_uint64_t                  aigp_metric;          /*   296     8 */

/* size: 304, cachelines: 5, members: 54 */
/* sum members: 302, holes: 1, sum holes: 2 */
/* last cacheline: 48 bytes */
};   /* saved 8 bytes! */
```

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>

bgpd: Save memory when using bgp_path_info_extra and vnc

Structure size of bgp_path_info_extra when compiled
with vnc is 184 bytes.  Reduce this size to 72 bytes
when compiled w/ vnc but not necessarily turned
on vnc.

With 2 full bgp feeds this saves aproximately 100mb
when compiling with vnc and not using vnc.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>

lib: Reduce size of hash_bucket by 8 bytes

pahole reports that the hash_bucket has 2 4 byte holes
in the data structure.  Let's reorganize this a bit
and save 8 bytes per hash_bucket instance.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>

tests: add mgmtd backend notification test

Signed-off-by: Christian Hopps <chopps@labn.net>

Merge pull request #15268 from LabNConsulting/chopps/quieter-code

lowercase and localize debug/err macros

redhat: add option to include mgmtd_testc test client

Signed-off-by: Christian Hopps <chopps@labn.net>

mgmtd: convert MGMTD_FE_CLIENT_DBG() to debug_fe_client()

Signed-off-by: Christian Hopps <chopps@labn.net>

mgmtd: convert MGMTD_BE_CLIENT_DBG() to debug_be_client()

Signed-off-by: Christian Hopps <chopps@labn.net>

mgmtd: convert MGMT_FE_ADAPTER_DBG() to __dbg()

Signed-off-by: Christian Hopps <chopps@labn.net>

mgmtd: convert MGMT_BE_ADAPTER_DBG() to __dbg()

Signed-off-by: Christian Hopps <chopps@labn.net>

mgmtd: convert MGMT_DS_DBG() to __dbg()

Signed-off-by: Christian Hopps <chopps@labn.net>

mgmtd: convert MGMT_TXN_DBG() to __dbg()

Signed-off-by: Christian Hopps <chopps@labn.net>

Merge pull request #15258 from louis-6wind/fix-adj-in-attr

bgpd: fix attr comparaison bgp_adj_in_set

Merge pull request #15251 from qlyoung/fix-doc-nbcli-numlist

doc: fix misformatted list in nbapi docs

Merge pull request #15246 from idryzhov/mgmt-get-data-improvements

mgmt get-data improvements

bgpd: Optimize memory for rd_ip struct

```
struct rd_ip {
uint16_t                   type;                 /*     0     2 */
uint16_t                   val;                  /*     2     2 */
struct in_addr             ip;                   /*     4     4 */

/* size: 8, cachelines: 1, members: 3 */
/* last cacheline: 8 bytes */
};   /* saved 4 bytes! */
```

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>

tests: add tests for mgmt get-data with-defaults parameter

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

mgmtd: add our own format definitions for frontend messages

It allows people not familiar with libyang and FRR internals to use
mgmtd FE API by looking only at `mgmt_msg_native.h` header. We still use
the same values to avoid a lot of mapping code, and ensure that any
change doesn't slip unnoticed by using static asserts.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

mgmtd: fix printing an empty data tree

We don't need to create an actual tree to print an empty tree, libyang
handles NULL just fine. The actual problem is that `yang_dnode_new`
creates a tree by validating it, and the validation creates all implicit
default nodes. Therefore, when called with "with-default" flags, instead
of getting an empty tree, we get a tree with all top-level default set.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

mgmtd: add ability to choose datastore to get data from

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

mgmtd: add support for with-defaults parameter to get-data

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

yang: add more ietf models

These models are needed to use LYD_PRINT_WD_ALL_TAG flag of libyang.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

Merge pull request #15254 from LabNConsulting/chopps/notifications

Add YANG notifications

Merge pull request #14764 from mjstapp/nb_gen_tool

tools, vtysh: add the cli write callback, unhide an NB show command

build: build: make mgmtd test client build conditional

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

mgmtd: backend subscriptions to notifications

Signed-off-by: Christian Hopps <chopps@labn.net>

Merge pull request #15257 from opensourcerouting/fix/reinstall_aggregate_route_if_rmap

bgpd: Reinstall aggregated routes if using route-maps and it was changed

tests: add YANG notification test

Signed-off-by: Christian Hopps <chopps@labn.net>

doc: update [no] recommendation

Signed-off-by: Quentin Young <qlyoung@qlyoung.net>

Merge pull request #15163 from opensourcerouting/fix/pam_account

packaging: Require account validation with pam_unix.so if PAM enabled

Merge pull request #15250 from opensourcerouting/fix/memory_optimizations

bgpd: Some memory optimizations

Merge pull request #15252 from mjstapp/fix_bitfield_init

lib: init new bitfield word after realloc

bgpd: fix attr comparaison bgp_adj_in_set

In bgp_adj_in_set(), attr has not yet been interned. adj->attr is always
different from attr. adj->attr is always uninterned and interned even if
attr and adj->attr are identical.

Fix the comparison.

Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>

tests: Check if attributes are reapplied for aggregate routes with route-maps

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>

bgpd: Reinstall aggregated routes if using route-maps and it was changed

Without this change when we change the route-map, we never reinstall the route
if the route-map has changed.

We checked only some attributes like aspath, communities, large-communities,
extended-communities, but ignoring the rest of attributes.

With this change, let's check if the route-map has changed.

bgp_route_map_process_update() is triggered on route-map change, and we set
`changed` to true, which treats aggregated route as not the same as it was before.

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>

doc: add doc for show configuration running

Add a doc entry for the newly-unhidden 'show configuration
running ...' command.

Signed-off-by: Mark Stapp <mjs@labn.net>

vtysh: un-hide the show configuration nb cli

The "show configuration running" cli is pretty useful when
doing NB work; unhide it so it's easier to use.

Signed-off-by: Mark Stapp <mjs@labn.net>

tools: add config-write callbacks to nb templates

Add the cli_show (config write) callback when emitting the
create or modify callback in the northbound template. Split
the config-handling and config-output callbacks into two
structs/arrays; this seems to be helpful when doing mgmtd
conversion.

Signed-off-by: Mark Stapp <mjs@labn.net>

lib: mgmtd: add YANG notification support

Signed-off-by: Christian Hopps <chopps@labn.net>

Merge pull request #15238 from louis-6wind/bgp-leak-network

bgpd: fix VRF leaking with 'network import-check'

bgpd: Optimize memory usage for bgp_damp_config struct

```
struct bgp_damp_config {
        unsigned int               suppress_value;       /*     0     4 */
        unsigned int               reuse_limit;          /*     4     4 */
        time_t                     max_suppress_time;    /*     8     8 */
        time_t                     half_life;            /*    16     8 */
        unsigned int               reuse_list_size;      /*    24     4 */
        unsigned int               reuse_index_size;     /*    28     4 */
        unsigned int               ceiling;              /*    32     4 */
        unsigned int               decay_rate_per_tick;  /*    36     4 */
        unsigned int               decay_array_size;     /*    40     4 */
        unsigned int               reuse_scale_factor;   /*    44     4 */
        double                     scale_factor;         /*    48     8 */
        double *                   decay_array;          /*    56     8 */
        /* --- cacheline 1 boundary (64 bytes) --- */
        int *                      reuse_index;          /*    64     8 */
        struct bgp_damp_info * *   reuse_list;           /*    72     8 */
        int                        reuse_offset;         /*    80     4 */
        safi_t                     safi;                 /*    84     4 */
        struct bgp_damp_info *     no_reuse_list;        /*    88     8 */
        struct event *             t_reuse;              /*    96     8 */
        afi_t                      afi;                  /*   104     4 */

        /* size: 112, cachelines: 2, members: 19 */
        /* padding: 4 */
        /* last cacheline: 48 bytes */
};   /* saved 8 bytes! */
```

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>

bgpd: Optimize memory usage for bgp_aggregate struct

```
struct bgp_aggregate {
        uint8_t                    summary_only;         /*     0     1 */
        uint8_t                    as_set;               /*     1     1 */
        uint8_t                    origin;               /*     2     1 */
        _Bool                      med_mismatched;       /*     3     1 */
        _Bool                      med_initialized;      /*     4     1 */
        _Bool                      match_med;            /*     5     1 */

        /* XXX 2 bytes hole, try to pack */

        struct {
                char *             name;                 /*     8     8 */
                struct route_map * map;                  /*    16     8 */
        } rmap;                                          /*     8    16 */
        long unsigned int          count;                /*    24     8 */
        long unsigned int          incomplete_origin_count; /*    32     8 */
        long unsigned int          egp_origin_count;     /*    40     8 */
        struct hash *              community_hash;       /*    48     8 */
        struct hash *              ecommunity_hash;      /*    56     8 */
        /* --- cacheline 1 boundary (64 bytes) --- */
        struct hash *              lcommunity_hash;      /*    64     8 */
        struct hash *              aspath_hash;          /*    72     8 */
        struct community *         community;            /*    80     8 */
        struct ecommunity *        ecommunity;           /*    88     8 */
        struct lcommunity *        lcommunity;           /*    96     8 */
        struct aspath *            aspath;               /*   104     8 */
        safi_t                     safi;                 /*   112     4 */
        uint32_t                   med_matched_value;    /*   116     4 */
        char *                     suppress_map_name;    /*   120     8 */
        /* --- cacheline 2 boundary (128 bytes) --- */
        struct route_map *         suppress_map;         /*   128     8 */

        /* size: 136, cachelines: 3, members: 22 */
        /* sum members: 134, holes: 1, sum holes: 2 */
        /* last cacheline: 8 bytes */
};
```

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>

bgpd: Optimize memory usage for bgp_static struct

```
struct bgp_static {
        int                        backdoor;             /*     0     4 */
        uint32_t                   label_index;          /*     4     4 */
        uint8_t                    valid;                /*     8     1 */

        /* XXX 1 byte hole, try to pack */

        uint16_t                   encap_tunneltype;     /*    10     2 */
        uint32_t                   igpmetric;            /*    12     4 */
        struct in_addr             igpnexthop;           /*    16     4 */
        uint32_t                   atomic;               /*    20     4 */
        struct {
                char *             name;                 /*    24     8 */
                struct route_map * map;                  /*    32     8 */
        } rmap;                                          /*    24    16 */
        struct prefix_rd           prd __attribute__((__aligned__(8))); /*    40    16 */
        char *                     prd_pretty;           /*    56     8 */
        /* --- cacheline 1 boundary (64 bytes) --- */
        mpls_label_t               label;                /*    64     4 */

        /* XXX 4 bytes hole, try to pack */

        esi_t *                    eth_s_id;             /*    72     8 */
        struct ethaddr *           router_mac;           /*    80     8 */
        struct prefix              gatewayIp __attribute__((__aligned__(8))); /*    88    56 */

        /* size: 144, cachelines: 3, members: 14 */
        /* sum members: 139, holes: 2, sum holes: 5 */
        /* forced alignments: 2 */
        /* last cacheline: 16 bytes */
} __attribute__((__aligned__(8)));   /* saved 8 bytes! */
```

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>

bgpd: Optimize memory usage for attr struct

```
struct attr {
struct aspath *            aspath;               /*     0     8 */
struct community *         community;            /*     8     8 */
long unsigned int          refcnt;               /*    16     8 */
_uint64_t                  flag;                 /*    24     8 */
struct in_addr             nexthop;              /*    32     4 */
uint32_t                   med;                  /*    36     4 */
uint32_t                   local_pref;           /*    40     4 */
ifindex_t                  nh_ifindex;           /*    44     4 */
uint8_t                    origin;               /*    48     1 */
uint8_t                    es_flags;             /*    49     1 */
uint8_t                    router_flag;          /*    50     1 */
uint8_t                    default_gw;           /*    51     1 */
enum pta_type              pmsi_tnl_type;        /*    52     4 */
uint32_t                   rmap_change_flags;    /*    56     4 */
struct in6_addr            mp_nexthop_global;    /*    60    16 */
/* --- cacheline 1 boundary (64 bytes) was 12 bytes ago --- */
struct in6_addr            mp_nexthop_local;     /*    76    16 */
ifindex_t                  nh_lla_ifindex;       /*    92     4 */
struct ecommunity *        ecommunity;           /*    96     8 */
struct ecommunity *        ipv6_ecommunity;      /*   104     8 */
struct lcommunity *        lcommunity;           /*   112     8 */
struct cluster_list *      cluster1;             /*   120     8 */
/* --- cacheline 2 boundary (128 bytes) --- */
struct transit *           transit;              /*   128     8 */
struct in_addr             mp_nexthop_global_in; /*   136     4 */
struct in_addr             aggregator_addr;      /*   140     4 */
struct in_addr             originator_id;        /*   144     4 */
uint32_t                   weight;               /*   148     4 */
as_t                       aggregator_as;        /*   152     4 */
uint8_t                    mp_nexthop_len;       /*   156     1 */
uint8_t                    mp_nexthop_prefer_global; /*   157     1 */
uint8_t                    sticky;               /*   158     1 */
uint8_t                    distance;             /*   159     1 */
uint16_t                   encap_tunneltype;     /*   160     2 */
uint8_t                    df_alg;               /*   162     1 */

/* XXX 1 byte hole, try to pack */

route_tag_t                tag;                  /*   164     4 */
uint32_t                   label_index;          /*   168     4 */
mpls_label_t               label;                /*   172     4 */
struct bgp_attr_srv6_vpn * srv6_vpn;             /*   176     8 */
struct bgp_attr_srv6_l3vpn * srv6_l3vpn;         /*   184     8 */
/* --- cacheline 3 boundary (192 bytes) --- */
struct bgp_attr_encap_subtlv * encap_subtlvs;    /*   192     8 */
struct bgp_attr_encap_subtlv * vnc_subtlvs;      /*   200     8 */
struct bgp_route_evpn      evpn_overlay;         /*   208    36 */
uint32_t                   mm_seqnum;            /*   244     4 */
uint32_t                   mm_sync_seqnum;       /*   248     4 */
struct ethaddr             rmac;                 /*   252     6 */
/* --- cacheline 4 boundary (256 bytes) was 2 bytes ago --- */
uint16_t                   df_pref;              /*   258     2 */
uint32_t                   rmap_table_id;        /*   260     4 */
uint32_t                   link_bw;              /*   264     4 */
esi_t                      esi;                  /*   268    10 */

/* XXX 2 bytes hole, try to pack */

uint32_t                   srte_color;           /*   280     4 */
uint32_t                   otc;                  /*   284     4 */
enum nexthop_types_t       nh_type;              /*   288     4 */
enum blackhole_type        bh_type;              /*   292     4 */
_uint64_t                  aigp_metric;          /*   296     8 */

/* size: 304, cachelines: 5, members: 53 */
/* sum members: 301, holes: 2, sum holes: 3 */
/* last cacheline: 48 bytes */
};   /* saved 16 bytes! */
```

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>

Merge pull request #15248 from LabNConsulting/chopps/fix-comp-warning

zebra: fix compiler warning about truncation.

lib: init new bitfield word after realloc

Realloc doesn't init - ensure a newly-allocated word is inited.

Signed-off-by: Mark Stapp <mjs@labn.net>

doc: fix misformatted list in nbapi docs

Signed-off-by: Quentin Young <qlyoung@qlyoung.net>

bgpd: Optimize memory usage for bgp_nlri struct

```
struct bgp_nlri {
uint16_t                   afi;                  /*     0     2 */
uint8_t                    safi;                 /*     2     1 */

/* XXX 1 byte hole, try to pack */

bgp_size_t                 length;               /*     4     2 */

/* XXX 2 bytes hole, try to pack */

uint8_t *                  nlri;                 /*     8     8 */

/* size: 16, cachelines: 1, members: 4 */
/* sum members: 13, holes: 2, sum holes: 3 */
/* last cacheline: 16 bytes */
};   /* saved 8 bytes! */
```

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>

zebra: fix compiler warning about truncation.

Signed-off-by: Christian Hopps <chopps@labn.net>

bgpd: Optimize memory usage for bgp_notify struct

```
struct bgp_notify {
uint8_t                    code;                 /*     0     1 */
uint8_t                    subcode;              /*     1     1 */
bgp_size_t                 length;               /*     2     2 */
_Bool                      hard_reset;           /*     4     1 */

/* XXX 3 bytes hole, try to pack */

char *                     data;                 /*     8     8 */
uint8_t *                  raw_data;             /*    16     8 */

/* size: 24, cachelines: 1, members: 6 */
/* sum members: 21, holes: 1, sum holes: 3 */
/* last cacheline: 24 bytes */
};   /* saved 16 bytes! */
```

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>

Merge pull request #15181 from idryzhov/zebra-mgmtd

zebra interfaces NB conversion

topotests: vpnv4 route leaking with import-check

Test vpnv4 route leaking with import-check

Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>

bgpd: fix VRF leaking with 'network import-check' (4/4)

The following configuration creates an infinite routing leaking loop
because 'rt vpn both' parameters are the same in both VRFs.

> router bgp 5227 vrf r1-cust4
>    no bgp network import-check
>    bgp router-id 192.168.1.1
>    address-family ipv4 unicast
>      network 28.0.0.0/24
>      rd vpn export 10:12
>      rt vpn both 52:100
>      import vpn
>      export vpn
>    exit-address-family
> !
> router bgp 5227 vrf r1-cust5
>    no bgp network import-check
>    bgp router id 192.168.1.1
>    address-family ipv4 unicast
>      network 29.0.0.0/24
>      rd vpn export 10:13
>      rt vpn both 52:100
>      import vpn
>      export vpn
>    exit-address-family

The previous commit has added a routing leak update when a nexthop
update is received from zebra. It indirectly calls
bgp_find_or_add_nexthop() in which a static route triggers a nexthop
cache entry registration that triggers a nexthop update from zebra.

Do not register again the nexthop cache entry if the BGP_STATIC_ROUTE is
already set.

Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>

bgpd: fix VRF leaking with 'network import-check' (3/4)

If 'bgp network import-check' is defined on the source BGP session,
prefixes that are defined with the network command cannot be leaked to
the other VRFs BGP table even if they are present in the origin VRF RIB
if the 'rt import' statement is defined after the 'network <prefix>'
ones.

When a prefix nexthop is updated, update the prefix route leaking. The
current state of nexthop validation is now stored in the attributes of
the bgp path info. Attributes are compared with the previous ones at
route leaking update so that a nexthop validation change now triggers
the update of destination VRF BGP table.

Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>

bgpd: fix VRF leaking with 'network import-check' (2/4)

"if not XX else" statements are confusing.

Replace two "if not XX else" statements by "if XX else" to prepare next
commits. The patch is only cosmetic.

Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>

bgpd: fix VRF leaking with 'network import-check' (1/4)

If 'bgp network import-check' is defined on the source BGP session,
prefixes that are defined with the network command cannot be leaked to
the other VRFs BGP table even if they are present in the origin VRF RIB.

Always validate the nexthop of BGP static routes (i.e. defined with the
network statement) if 'network import-check' is defined on the source
BGP session and the prefix is present in source RIB.

Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>

Merge pull request #15245 from idryzhov/disable-irdp

zebra, build: disable irdp by default

zebra, build: disable irdp by default

IRDP client (rdisc) was deleted from iputils more than 2 years ago. It's
time to drop IRDP, but first let's stop building and including it in the
packages by default to see if anyone will be complaining.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

lib, mgmtd, zebra: cleanup of zebra conversion to mgmtd

- use `apply_finish` callback when possible to avoid multiple applies per commit
- move table range working to the CLI handler
- remove unnecessary conditional compilation
- remove unnecessary boolean conversion

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

zebra: convert to mgmtd

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

build: remove mgmtd exception from xref2vtysh

We may actually need to send CLI commands to mgmtd and another daemon at
the same time, for example, if this daemon is not mgmtd-converted. The
only daemon this exception protects is staticd. But we don't actually
need any configuration commands in staticd, so just remove the exception
and don't install unnecessary commands to staticd.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

lib: use shared candidate between vty and mgmtd client

When the daemon is partially mgmtd-converted, it receives configuration
from vty and mgmtmd simultaneosly. This configuration must be
synchronized.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

lib: convert affinity-map to mgmtd

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

lib: fix yang_dnode_dup

When duplicating nodes, we should always keep flags, especially the
LYD_NEW flag that indicates not validated data. This allows to select a
new choice's case without the need to explicitly remove the existing one.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

zebra: convert vrf configuration output to NB

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

zebra: make vrf netns commands do nothing

These commands don't really provide any functionality. VRF is associated
with netns automatically based on its name, and it's not possible to
associate VRF and netns with different names with these commands:

- When trying to assosiate a VRF with an already existing netns with a
  different name:
  `NS /run/netns/test is already configured with VRF 1(test)`

- When trying to assiciate a VRF with a non-existing netns, so they
  become linked once the netns is created:
  `Invalid pathname for /run/netns/test: No such file or directory`

- When doing "no netns" to unlink the netns and link it back to the same
  VRF:
  `VRF 1 is already configured with VRF test`

- When doing "no netns" to unlink the netns and link it to another VRF:
  `Can not associate NS 4294967295 with NETNS /run/netns/test`

As shown above, not a single usecase is working. We can't remove them
completely to preserve backwards-compatibility, so just make them empty.

The main reason for this change is not to spend a lot of time trying to
figure out how to convert them to northbound.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

zebra: convert table range command to NB

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

zebra: convert resolve-via-default commands to NB

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

zebra: fix vni NB conversion

- unnecessary command duplication
- usage of oper data during validation
- unnecessary checks for things that can't happen

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

zebra: convert route-map delay-timer command to NB

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

zebra: convert ip nht commands to NB

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

zebra: convert ip protocol commands to NB

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

zebra: convert router-id commands to NB

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

zebra: convert interface configuration output to NB

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

zebra: fix build with --disable-rtadv

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

zebra: convert PTM configuration to NB

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

lib: add support for "features" when loading YANG modules

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

zebra: convert interface ipv6 nd dnssl command to NB

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

zebra: convert interface ipv6 nd rdnss command to NB

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

zebra: convert interface ipv6 nd prefix command to NB

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

zebra: convert interface ipv6 nd router-preference command to NB

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

zebra: convert interface ipv6 nd home-agent-lifetime command to NB

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

zebra: convert interface ipv6 nd home-agent-preference command to NB

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

zebra: convert interface ipv6 nd adv-interval-option command to NB

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

zebra: convert interface ipv6 nd home-agent-config-flag command to NB

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

zebra: convert interface ipv6 nd ra-fast-retrans command to NB

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

zebra: convert interface ipv6 nd ra-hop-limit command to NB

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

zebra: convert interface ipv6 nd ra-retrans-interval command to NB

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

zebra: convert interface ipv6 nd mtu command to NB

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

zebra: convert interface ipv6 nd other-config-flag command to NB

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

zebra: convert interface ipv6 nd managed-config-flag command to NB

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>