Merge pull request #16748 from opensourcerouting/fix/issue_12502

bgpd: Validate imported routes next-hop that is in a default VRF

Merge pull request #15259 from dmytroshytyi-6WIND/nexthop_resolution

zebra: add LSP entry to nexthop via recursive (part 2)

Merge pull request #16768 from sri-mohan1/srib-24-frr-a

bgpd: changes for code maintainability

bgpd: changes for code maintainability

these changes are for improving the code maintainability and readability

Signed-off-by: sri-mohan1 <sri.mohan@samsung.com>

Merge pull request #16777 from LabNConsulting/chopps/pytest-config-update

tests: add asyncio default config param to quiet warning

tests: add asyncio default config param to quiet warning

Update the topotest doc to the latest pytest* pkg versions
known to work together

Signed-off-by: Christian Hopps <chopps@labn.net>

Merge pull request #16764 from LabNConsulting/chopps/fix-clang-sa-warning

lib: fix clang SA warnings

Merge pull request #15679 from cscarpitta/test-srv6-sid-manager

tests: Add topotest to validate the sharing of an SRv6 locator among multiple protocols

Merge pull request #16756 from sri-mohan1/srib-24-frr-a

bgpd: changes for code maintainability

lib: fix clang SA warnings

Also, cleanup some unreachable code in `nb_op_sib_next()`.

Signed-off-by: Christian Hopps <chopps@labn.net>

Merge pull request #16762 from LabNConsulting/chopps/diag-diff

improve @retry decorator

tests: log json diff output at debug level while retrying

Signed-off-by: Christian Hopps <chopps@labn.net>

tests: optionally pass `seconds_left` to retrying functions

This allows retrying functions to possibly change their logging level
for diagnostics.

In order to maintain backward compatibility with this longstanding
function we catch the specific exception of it not being handled by the
retrying function and call again w/o the argument.

Signed-off-by: Christian Hopps <chopps@labn.net>

tests: Add SRv6 SID Manager mem leak testcase

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add SRv6 SID Manager ping testcase

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add SRv6 SID Manager VPN RIB testcase

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add SRv6 SID Manager SRv6 loc testcase

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add SRv6 SID Manager RIB IPv6 testcase

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add SRv6 SID Manager RIB IPv4 testcase

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add SRv6 SID Manager ISIS adj testcase

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: SRv6 SID Manager check rib

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: SRv6 SID Manager open json

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: SRv6 SID Manager check ping

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: SRv6 SID Manager json cmp

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: SRv6 SID Manager teardown module

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: SRv6 SID Manager setup module

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: SRv6 SID Manager build topology

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add SRv6 SID Manager topotest

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt6 vpn rib

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt6 vrf20 rib

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt6 vrf10 rib

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt6 ISIS adj

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt6 SRv6 locators

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt6 ipv6 routes

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt6 ip routes

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add zebra configuration for rt6

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add sharp configuration for rt6

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add ISIS configuration for rt6

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add BGP configuration for rt6

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt5 ISIS adj

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt5 SRv6 locators

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt5 ipv6 routes

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt5 ip routes

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add zebra configuration for rt5

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add ISIS configuration for rt5

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt4 ISIS adj

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt4 SRv6 locators

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt4 ipv6 routes

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt4 ip routes

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add zebra configuration for rt4

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add ISIS configuration for rt4

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt3 ISIS adj

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt3 SRv6 locators

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt3 ipv6 routes

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt3 ip routes

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add zebra configuration for rt3

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add ISIS configuration for rt3

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt2 ISIS adj

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt2 SRv6 locators

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt2 ipv6 routes

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt2 ip routes

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add zebra configuration for rt2

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add ISIS configuration for rt2

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt1 ISIS adj

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt1 SRv6 locators

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt1 ipv6 routes

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt1 ip routes

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt1 vpn rib

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt1 vrf20 rib

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt1 vrf10 rib

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add zebra configuration for rt1

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add sharp configuration for rt1

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add ISIS configuration for rt1

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add BGP configuration for rt1

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add zebra configuration for dst

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add sharp configuration for dst

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify ce6 rib

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add zebra configuration for ce6

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add BGP configuration for ce6

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify ce5 rib

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add zebra configuration for ce5

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add BGP configuration for ce5

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify ce4 rib

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add zebra configuration for ce4

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add BGP configuration for ce4

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify ce3 rib

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add zebra configuration for ce3

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add BGP configuration for ce3

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify ce2 rib

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add zebra configuration for ce2

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add BGP configuration for ce2

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify ce1 rib

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add zebra configuration for ce1

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add BGP configuration for ce1

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

Merge pull request #16721 from opensourcerouting/fix/drop_not_used_rmap_types

bgpd: Drop unused route-map types

Merge pull request #16758 from donaldsharp/recalculate_less_often

bgpd: Reduce # of iterations when doing llgr

Merge pull request #16757 from mjstapp/fix_ospfd_dlist_sa

ospfd: add assert to resolve SA warning

bgpd: Reduce # of iterations when doing llgr

Code was scanning a table then identifying a prefix
that needed to be modified then calling code that
reran bestpath on the entire table again.

If you had multiple items that needed processing
you would end up scanning and setting the entire
table to be scanned multiple times.  No bueno.

a) We do not need to reprocess items that are not
being modified.

b) We do not need to walk the entire table multiple
times, we have the data that is needed already.

Modify the code to just call bgp_process on the
interesting nodes.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>

ospfd: add assert to resolve SA warning

Resolve a couple of SA warnings by asserting that pointers are
valid.

Signed-off-by: Mark Stapp <mjs@cisco.com>

bgpd: changes for code maintainability

these changes are for improving the code maintainability and readability

Signed-off-by: sri-mohan1 <sri.mohan@samsung.com>