]>
git.puffer.fish Git - mirror/frr.git/log
Russ White [Fri, 26 Apr 2024 18:41:05 +0000 (14:41 -0400)]
Merge pull request #15723 from opensourcerouting/feature/extended_link_bw_refactored_v1
bgpd: Implement extended link-bandwidth
Donald Sharp [Fri, 26 Apr 2024 14:19:05 +0000 (10:19 -0400)]
Merge pull request #15588 from opensourcerouting/sqlite-filename-size
lib: fix SQLite dbfile path length
Mark Stapp [Fri, 26 Apr 2024 13:31:44 +0000 (09:31 -0400)]
Merge pull request #15843 from opensourcerouting/yang-link-netconf-acm
yang: ietf-netconf-acm needs to be in libfrr
Mark Stapp [Fri, 26 Apr 2024 12:01:26 +0000 (08:01 -0400)]
Merge pull request #15850 from donaldsharp/sa_clang_15_some_problems
bgpd: Remove unused addition found in clang
Donald Sharp [Fri, 26 Apr 2024 11:38:42 +0000 (07:38 -0400)]
Merge pull request #15744 from pguibert6WIND/snmp_oid_line73_error
topotests: lib, fix filter out "At line 73 in /usr/share/snmp/mibs/ie…
Donatas Abraitis [Fri, 26 Apr 2024 09:52:37 +0000 (12:52 +0300)]
Merge pull request #15849 from donaldsharp/redistibute_doc_change
bgpd: Explain Better admin w/ redistribution a bit better.
Donald Sharp [Thu, 25 Apr 2024 18:45:32 +0000 (14:45 -0400)]
bgpd: Remove unused addition found in clang
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Donald Sharp [Thu, 25 Apr 2024 18:17:46 +0000 (14:17 -0400)]
bgpd: Explain Better admin w/ redistribution a bit better.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
David Lamparter [Thu, 25 Apr 2024 13:06:14 +0000 (15:06 +0200)]
yang: ietf-netconf-acm needs to be in libfrr
ietf-key-chain depends on ietf-netconf-acm, and lib/ code sets up the
former, so ietf-netconf-acm needs to be embedded in the libfrr too.
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
David Lamparter [Thu, 25 Apr 2024 11:10:43 +0000 (13:10 +0200)]
Merge pull request #15833 from mjstapp/fix_vtysh_bgp_defs
Donatas Abraitis [Wed, 24 Apr 2024 19:33:37 +0000 (22:33 +0300)]
Merge pull request #15794 from chiragshah6/fdev2
tools: fix pim interface config deletion II
Donatas Abraitis [Wed, 24 Apr 2024 19:30:11 +0000 (22:30 +0300)]
Merge pull request #15783 from LabNConsulting/aceelindem/ospf-neighbor-filter
ospfd: Add prefix-list filtering of OSPF neighbors on OSPF interface
Donald Sharp [Wed, 24 Apr 2024 14:16:59 +0000 (10:16 -0400)]
Merge pull request #15805 from LabNConsulting/working/lb/nhrp-retry-based-on-config2
nhrp: replace hard coded retry time with value derived from holdtime
Mark Stapp [Wed, 24 Apr 2024 12:23:12 +0000 (08:23 -0400)]
lib,bgpd,vtysh: move bgp vty defines to lib
Stop including a bgp header file from vtysh; move a couple
of cli string defines to a library header.
Signed-off-by: Mark Stapp <mjs@cisco.com>
Donatas Abraitis [Wed, 24 Apr 2024 11:34:19 +0000 (14:34 +0300)]
Merge pull request #15766 from louis-6wind/fix-network-rd
bgpd: fix show run of network route-distinguisher
Donald Sharp [Wed, 24 Apr 2024 11:25:22 +0000 (07:25 -0400)]
Merge pull request #15819 from louis-6wind/fix-snmp-oid
bgpd, ospfd: fix non increasing SNMP OID
Chirag Shah [Tue, 23 Apr 2024 02:47:27 +0000 (19:47 -0700)]
tools: fix frr-reload for no ip msdp peer cmd
no form of 'ip pm msdp peer <> source <>' does not
accept source argument. Stip the 'source <>' part from
config line being deleted via frr-reload.
Ticket: #
3874971
Testing:
Config:
vrf blue
ip msdp peer 1.1.1.1 source 1.1.1.1
frr-reload failure log:
2024-04-23 02:08:32,501 INFO: Failed to execute vrf blue no ip
msdp peer 1.1.1.1 source 1.1.1.1 exit
2024-04-23 02:08:32,501 ERROR: "vrf blue -- no ip msdp peer 1.1.1.1
source 1.1.1.1 -- exit" we failed to remove this command
2024-04-23 02:08:32,501 ERROR: % Unknown command: no ip msdp peer
1.1.1.1 source 1.1.1.1
Signed-off-by: Chirag Shah <chirag@nvidia.com>
Chirag Shah [Thu, 18 Apr 2024 18:44:00 +0000 (11:44 -0700)]
tools: fix pim interface config deletionII
When no ip pim is performed subsequent pim related
configs under the interface also implicitly deleted.
The previous fix was attempting to remove from the same
list which was being integrated.
First collect the lines to remove in separate list
then at the end remove from the original lines_to_del.
commit
623af04e1c does not work properly if tries to delete
an entry from existing list which is being walked on.
Ticket: #
3869779
Testing done:
frr.conf:
no interface config
running-config:
--------------
interface swp1
ip pim
ip pim active-active
ip pim allow-rp rp-list sample
ip pim bfd
ip pim use-source 1.1.1.1
ip multicast boundary oil test
exit
frr-reload log pointing only no ip pim config
is removed under interface:
2024-04-18 18:44:37,202 INFO: "frr defaults datacenter" cannot be removed
2024-04-18 18:44:37,202 INFO: "service integrated-vtysh-config" cannot be removed
2024-04-18 18:44:37,504 INFO: Executed "interface swp1 no ip pim exit"
2024-04-18 18:44:37,505 INFO: /var/run/frr/reload-YHS51E.txt content
Signed-off-by: Chirag Shah <chirag@nvidia.com>
Mark Stapp [Tue, 23 Apr 2024 17:01:35 +0000 (13:01 -0400)]
Merge pull request #15769 from raja-rajasekar/rajasekarr/backpressure_display_i_o_buf
zebra: Actually display I/O buffer sizes (part-2)
Donald Sharp [Tue, 23 Apr 2024 16:58:48 +0000 (12:58 -0400)]
Merge pull request #15801 from LabNConsulting/chopps/new-munet
Improve coverage functionality
Donald Sharp [Tue, 23 Apr 2024 16:57:24 +0000 (12:57 -0400)]
Merge pull request #15810 from opensourcerouting/fix/enforce_first_as_bgp_peer-group
bgpd: Inherit some peer flags from the peer-group
Donald Sharp [Tue, 23 Apr 2024 16:55:27 +0000 (12:55 -0400)]
Merge pull request #15714 from mjstapp/sync_pthread_startup
lib: serialize pthread startup
Lou Berger [Tue, 23 Apr 2024 15:51:33 +0000 (11:51 -0400)]
nhrp: replace hard coded retry time with value derived from holdtime
Signed-off-by: Lou Berger <lberger@labn.net>
Philippe Guibert [Mon, 15 Apr 2024 12:12:23 +0000 (14:12 +0200)]
topotests: lib, fix filter out "At line 73 in /usr/share/snmp/mibs/ietf/SNMPv2-PDU" message
When testing SNMP service on FRR, the following error message may
appear on some distros.
> # snmpwalk -v2c -c public .1.3.6 1.1.1.1 <OID>
> Bad operator (INTEGER): At line 73 in /usr/share/snmp/mibs/ietf/SNMPv2-PDU
> [..then result ..]
>
The error message is due to the /etc/snmp/snmp.conf file. By default, this
file is used by both snmp server and client side. The net-snmp MIB parsing
routing loads MIBS, to bind oids with the naming scheme used by the MIBS.
> # cat /etc/frr/snmp.conf
> [snmp]
> mibs +ALL
>
A potential fix would consist in modifying the SNMPv2-PDU.mib file: the
problem is known on ubuntu distros, as the snmp-mibs-downloader package
has not updated the SNMPv2-PDU.mib file.
The choice is done to not modify the original distro where the test is run
on. Fix the topotests by ignoring the 'SNMPv2-PDU line 73" error message, and
keep the other error messages that may happen, for instance, when an
unknown oid name value is requested.
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
Mark Stapp [Tue, 23 Apr 2024 12:08:43 +0000 (08:08 -0400)]
Merge pull request #15815 from donaldsharp/blackhole_reinstall
lib, zebra: Check for not being a blackhole route
Louis Scalbert [Tue, 23 Apr 2024 09:39:29 +0000 (11:39 +0200)]
Revert "bgpd: fix pointer arithmetic in bgp snmp module"
This reverts commit
d9bd9ebbf1c3ab902133e7f47c4b8c073e2df3d4 .
The previous code was correct even if the coverity scanner was
complaining.
Fixes: https://github.com/FRRouting/frr/issues/15680
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
Louis Scalbert [Tue, 23 Apr 2024 09:36:14 +0000 (11:36 +0200)]
Revert "ospfd: fix some dicey pointer arith in snmp module"
This reverts commit
438ef98701e9922e81a451f87ad053268a1a557e .
The previous code was correct even if the coverity scanner was
complaining.
Fixes: https://github.com/FRRouting/frr/issues/15680
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
Louis Scalbert [Tue, 16 Apr 2024 14:41:51 +0000 (16:41 +0200)]
bgpd: fix show run of network route-distinguisher
Route-distinguisher (RD) is not printed properly in show run:
> address-family ipv6 vpn
> network ff01::/64 rd (null) label 7
> network ff01::/64 rd (null) label 8
ad151f66aa ("bgpd: Refactor bgp_static_set/bgp_static_set_safi") merged
bgp_static_set_safi into bgp_static_set but inadvertently omitted the
handling of prd_pretty.
Copy the pretty RD string if available.
> address-family ipv6 vpn
> network ff01::/64 rd 75:5 label 7
> network ff01::/64 rd 85:5 label 8
Fixes: ad151f66aa ("bgpd: Refactor bgp_static_set/bgp_static_set_safi")
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
Igor Ryzhov [Tue, 23 Apr 2024 08:11:08 +0000 (11:11 +0300)]
Merge pull request #15813 from pguibert6WIND/isis_srv6_backup_endx
isisd: fix renaming backup define for ENDX SID
Donatas Abraitis [Tue, 23 Apr 2024 08:09:11 +0000 (11:09 +0300)]
Merge pull request #15536 from ak503/bgp_bfd
bgpd: fix disable bfd profile for neighbors.
Donatas Abraitis [Tue, 23 Apr 2024 08:08:21 +0000 (11:08 +0300)]
Merge pull request #15717 from pguibert6WIND/vrf_label_allocate_when_necessary
bgpd: do allocate vrf label only when necessary
Donatas Abraitis [Tue, 23 Apr 2024 08:06:44 +0000 (11:06 +0300)]
Merge pull request #15750 from piotrsuchy/json_show_ip_prefix_list_fix
vtysh, lib: fix 'show ip[v6] prefix-list ... json' JSON display by moving it to vtysh to fix formatting issue
Donatas Abraitis [Tue, 23 Apr 2024 05:52:31 +0000 (08:52 +0300)]
bgpd: Update IPv6 extended community sub-type for extended link bandwidth
Already assigned by IANA, just the draft is not yet updated.
https://www.iana.org/assignments/bgp-extended-communities/bgp-extended-communities.xhtml#trans-ipv6
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Donatas Abraitis [Sat, 13 Apr 2024 19:05:20 +0000 (22:05 +0300)]
tests: Check if extended link bandwidth can be more than 25gbps
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Donatas Abraitis [Thu, 11 Apr 2024 10:15:21 +0000 (13:15 +0300)]
bgpd: Use snprintfrr() to print PRIu64 for ipv6_ecommunity_lb_str()
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Donatas Abraitis [Thu, 11 Apr 2024 08:55:06 +0000 (11:55 +0300)]
tests: Check if extended link bandwidth is considered into also
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Donatas Abraitis [Thu, 11 Apr 2024 08:52:02 +0000 (11:52 +0300)]
bgpd: Include IPv6 extended community into multipath considerations
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Donatas Abraitis [Wed, 10 Apr 2024 13:33:14 +0000 (16:33 +0300)]
bgpd: Extract link bandwidth from IPv6 extended community if received
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Donatas Abraitis [Wed, 10 Apr 2024 13:13:57 +0000 (16:13 +0300)]
*: Use uint64_t for weight down the path to Zebra
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Donatas Abraitis [Wed, 10 Apr 2024 10:34:47 +0000 (13:34 +0300)]
bgpd: Allow sending extended communities between OAD peers
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Donatas Abraitis [Wed, 10 Apr 2024 07:16:01 +0000 (10:16 +0300)]
bgpd: Implement draft-li-idr-link-bandwidth-ext-01
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Donatas Abraitis [Wed, 10 Apr 2024 10:35:09 +0000 (13:35 +0300)]
bgpd: Print IPv6 extended communities for `show bgp <prefix>`
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Donatas Abraitis [Mon, 8 Apr 2024 06:07:01 +0000 (09:07 +0300)]
bgpd: Add `neighbor ... extended-link-bandwidth` command
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Donatas Abraitis [Wed, 10 Apr 2024 08:31:43 +0000 (11:31 +0300)]
bgpd: Print IPv6 extended community for `show bgp attribute-info`
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Donatas Abraitis [Wed, 10 Apr 2024 07:12:02 +0000 (10:12 +0300)]
bgpd: Adopt ecommunity_linkbw_present for IPv6 extended communities
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Donatas Abraitis [Mon, 8 Apr 2024 06:26:29 +0000 (09:26 +0300)]
bgpd: Drop non ieee encoding parsing for ipv6 extended communities
Link-bandwidth is encoded into extended community, not ipv6 extended community.
Thus it's not needed here at all.
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Donatas Abraitis [Mon, 8 Apr 2024 06:22:02 +0000 (09:22 +0300)]
bgpd: Convert 32-bit to 64-bit link bandwidth variable (link_bw)
This is needed to implement and use larger bandwidths rather than limiting only
to theoretical 34Gbps max bandwidth.
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Donatas Abraitis [Wed, 10 Apr 2024 10:43:15 +0000 (13:43 +0300)]
doc: Add `neighbor ... extended-link-bandwidth` command
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Donald Sharp [Fri, 19 Apr 2024 16:13:32 +0000 (12:13 -0400)]
lib, zebra: Check for not being a blackhole route
In zebra_interface_nhg_reinstall zebra is checking that the
nhg is a singleton and not a blackhole nhg. This was originally
done with checking that the nexthop is a NEXTHOP_TYPE_IFINDEX,
NEXTHOP_TYPE_IPV4_IFINDEX and NEXTHOP_TYPE_IPV6_IFINDEX. This
was excluding NEXTHOP_TYPE_IPV4 and NEXTHOP_TYPE_IPV6. These
were both possible to be received and maintained from the upper
level protocol for when a route is being recursively resolved.
If we have gotten to this point in zebra_interface_nhg_reinstall
the nexthop group has already been installed at least once
and we *know* that it is actually a valid nexthop. What the
test is really trying to do is ensure that we are not reinstalling
a blackhole nexthop group( Which is not possible to even be
here by the way, but safety first! ). So let's change
to test for that instead.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Christian Hopps [Mon, 22 Apr 2024 09:42:44 +0000 (05:42 -0400)]
Merge pull request #15468 from idryzhov/mgmt-native-edit
mgmtd: add support for native 'edit' operation
Philippe Guibert [Fri, 19 Apr 2024 13:46:20 +0000 (15:46 +0200)]
isisd: fix renaming backup define for ENDX SID
The define has inheritated from a wrong naming in sr-mpls.
Fix this by renaming ISIS_SRV6_LAN_BACKUP to ISIS_SRV6_ADJ_BACKUP.
Fixes: 2566656a6f50 ("isisd: Add data structure for SRv6 Adjacency SIDs")
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
Piotr Suchy [Mon, 15 Apr 2024 19:33:40 +0000 (21:33 +0200)]
vtysh, lib: fix 'show ip[v6] prefix-list ... json' formatting by moving it to vtysh
Json output is not valid for 'show ip[v6] prefix-list ... json' commands,
as it goes through all the running daemons and for each one it calls
'vty_show_prefix_list' creating a new json object. To aggreagate the output
and create a valid json that can be parsed, the commands were moved to vtysh.
Before:
{
"ZEBRA":{
"DEFAULT":{
"addressFamily":"IPv4",
"entries":[
{
"sequenceNumber":10,
"type":"permit",
"prefix":"0.0.0.0/0"
}
]
}
}
}
{
"OSPF":{
"DEFAULT":{
"addressFamily":"IPv4",
"entries":[
{
"sequenceNumber":10,
"type":"permit",
"prefix":"0.0.0.0/0"
}
]
}
}
}
{
"BGP":{
"DEFAULT":{
"addressFamily":"IPv4",
"entries":[
{
"sequenceNumber":10,
"type":"permit",
"prefix":"0.0.0.0/0"
}
]
}
}
}
After:
{"zebra":{
"DEFAULT":{
"addressFamily":"IPv4",
"entries":[
{
"sequenceNumber":10,
"type":"permit",
"prefix":"0.0.0.0/0"
}
]
}
}
,"ospfd":{
"DEFAULT":{
"addressFamily":"IPv4",
"entries":[
{
"sequenceNumber":10,
"type":"permit",
"prefix":"0.0.0.0/0"
}
]
}
}
,"bgpd":{
"DEFAULT":{
"addressFamily":"IPv4",
"entries":[
{
"sequenceNumber":10,
"type":"permit",
"prefix":"0.0.0.0/0"
}
]
}
}
}
Signed-off-by: Piotr Suchy <piotrsuchy@proton.me>
Donatas Abraitis [Sun, 21 Apr 2024 19:29:32 +0000 (22:29 +0300)]
bgpd: Do not reset the session when toggling dynamic capability
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Donald Sharp [Sun, 21 Apr 2024 14:59:11 +0000 (10:59 -0400)]
Merge pull request #15738 from idryzhov/bfd-cbit
bfdd: fix BFD_GETCBIT
Donatas Abraitis [Sun, 21 Apr 2024 11:19:12 +0000 (14:19 +0300)]
bgpd: Inherit `capability dynamic` flag from the peer-group
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Donatas Abraitis [Sun, 21 Apr 2024 11:18:39 +0000 (14:18 +0300)]
bgpd: Inherit `capability software-version` flag from the peer-group
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Donatas Abraitis [Sun, 21 Apr 2024 11:16:49 +0000 (14:16 +0300)]
bgpd: Inherit `enforce-first-as` flag from the peer-group
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Igor Ryzhov [Sat, 20 Apr 2024 18:25:28 +0000 (21:25 +0300)]
Merge pull request #15803 from LabNConsulting/chopps/add-missing-zif-type
yang: add missing `zif-gre` zebra interface type
Donald Sharp [Sat, 20 Apr 2024 13:05:39 +0000 (09:05 -0400)]
Merge pull request #15798 from opensourcerouting/fix/show_route_map
vtysh: Fix `show route-map` command when calling via `do`
Christian Hopps [Sat, 20 Apr 2024 11:59:02 +0000 (07:59 -0400)]
yang: add missing `zif-gre` zebra interface type
This was caught by the grpc_basic test which was receiving an invalid error
result, which was returned b/c inside zebra the libyang code was flagging the
value as invalid for a derived zebra interface type.
Signed-off-by: Christian Hopps <chopps@labn.net>
Christian Hopps [Sat, 20 Apr 2024 08:31:03 +0000 (04:31 -0400)]
tests: improve coverage no need to modify source/build dir
- by using symlinks in the rundir (/tmp) into the source/build directory
we avoid needing to copy the *.gcda stat files into the source/build dir.
Signed-off-by: Christian Hopps <chopps@labn.net>
Donatas Abraitis [Sat, 20 Apr 2024 08:28:04 +0000 (11:28 +0300)]
Merge pull request #15472 from louis-6wind/ipv6-table-direct
bgpd: add redistribute table-direct command for ipv6-unicast
Christian Hopps [Sat, 20 Apr 2024 07:29:03 +0000 (03:29 -0400)]
tests: update munet to 0.14.0 release
Signed-off-by: Christian Hopps <chopps@labn.net>
Donald Sharp [Fri, 19 Apr 2024 17:25:50 +0000 (13:25 -0400)]
Merge pull request #15792 from opensourcerouting/fix/bgp_send_notification_with_data
bgpd: Include capabilities when sending NOTIFICATION(7)
Donatas Abraitis [Fri, 19 Apr 2024 16:17:11 +0000 (19:17 +0300)]
vtysh: Fix `show route-map` command when calling via `do`
Before:
```
ton(config)# do sh route-map
% [ZEBRA] Unknown command: show route-map
% [BGP] Unknown command: show route-map
% [ISIS] Unknown command: show route-map
```
Fixes: 570fdc55fd65899cd4376193e833594af6bca093 ("lib,vtysh: fix show route map JSON output")
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Renato Westphal [Wed, 17 Apr 2024 14:01:23 +0000 (11:01 -0300)]
tests: fix BFD C-bit topotest
When a BFD down notification is received and the C-bit is set in both
directions, any ongoing graceful restart should be aborted and stale
routes removed from the RIB.
This commit updates the `bfd_bgp_cbit_topo3` topotest accordingly to
fix the expected outcomes in the `test_bfd_loss_intermediate` test.
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
Acee Lindem [Wed, 17 Apr 2024 20:14:56 +0000 (20:14 +0000)]
ospfd: Add prefix-list filtering of OSPF neighbors on OSPF interface
This commit adds the capabiity to filter OSPF neighbors using a
prefix-list with rules matching the neighbor's IP source address.
Configuration, filtering, immediate neighbor pruning, topo-tests,
and documentation are included. The command is:
ip ospf neighbor-filter <prefix-list> [A.B.C.D]
Signed-off-by: Acee Lindem <acee@lindem.com>
Donatas Abraitis [Thu, 18 Apr 2024 14:37:51 +0000 (17:37 +0300)]
bgpd: Include capabilities when sending NOTIFICATION(7)
RFC5492 says:
This document defines a new Error Subcode, Unsupported Capability.
The value of this Subcode is 7. The Data field in the NOTIFICATION
message MUST list the set of capabilities that causes the speaker to
send the message. Each such capability is encoded in the same way as
it would be encoded in the OPEN message.
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Philippe Guibert [Tue, 9 Apr 2024 15:09:39 +0000 (17:09 +0200)]
bgpd: do allocate vrf label only when necessary
Today, with the following bgp instance configured, the
local VRF label is allocated even if it is not used.
> router bgp 65500 vrf vrf1
> address-family ipv4 unicast
> label vpn export allocation-mode per-nexthop
> label vpn export auto
> rd vpn export 444:1
> rt vpn both 52:100
> export vpn
> import vpn
The 'show mpls table' indicates that the 16 label value
is allocated, but never used in the exported prefixes.
> r1# show mpls table
> Inbound Label Type Nexthop Outbound Label
> -----------------------------------------------------
> 16 BGP vrf1 -
> 17 BGP 192.168.255.13 -
> 18 BGP 192.0.2.12 -
> 19 BGP 192.0.2.11 -
Fix this by only allocating new label values when really
used. Consequently, only 3 labels will be allocated instead
of previously 4.
> r1# show mpls table
> Inbound Label Type Nexthop Outbound Label
> -----------------------------------------------------
> 16 BGP 192.168.255.13 -
> 17 BGP 192.0.2.11 -
> 18 BGP 192.0.2.12 -
Fixes: 577be36a41be ("bgpd: add support for l3vpn per-nexthop label")
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
Jafar Al-Gharaibeh [Thu, 18 Apr 2024 06:33:07 +0000 (01:33 -0500)]
Merge pull request #15770 from idryzhov/fix-yang-exit
lib, zebra: fix exit commands
Donatas Abraitis [Thu, 18 Apr 2024 06:31:39 +0000 (09:31 +0300)]
Merge pull request #15780 from donaldsharp/rpki_as_0
bgpd: Allow specification of AS 0 for rpki commands
Donatas Abraitis [Wed, 17 Apr 2024 19:01:20 +0000 (22:01 +0300)]
Merge pull request #15775 from Shbinging/fix_ospf_vtysh_commands
ospfd: fix 'no maximum-paths' 'no write-multiplier' commands
Donald Sharp [Wed, 17 Apr 2024 17:26:36 +0000 (13:26 -0400)]
Merge pull request #15771 from idryzhov/fix-keychain-crash
lib: fix keychain NB crash
Donatas Abraitis [Wed, 17 Apr 2024 16:17:54 +0000 (19:17 +0300)]
Merge pull request #15774 from louis-6wind/cleanup-allow-martians
bgpd: cleanup references to debug bgp allow-martians
Igor Ryzhov [Wed, 17 Apr 2024 15:10:09 +0000 (18:10 +0300)]
Merge pull request #15758 from opensourcerouting/pkg_libyang_versions
debian, redhat, snapcraft: Libyang min version is 2.1.128
Donald Sharp [Wed, 17 Apr 2024 13:40:00 +0000 (09:40 -0400)]
bgpd: Allow specification of AS 0 for rpki commands
RFC-7607 specifically calls out the allowed usage
of AS 0 to signal that the a particular address is
not in use and should be guarded against. Add
the ability to specify this special AS in the rpki
commands.
eva# show rpki as-number 0
RPKI/RTR prefix table
Prefix Prefix Length Origin-AS
2.57.180.0 22 - 24 0
2.58.144.0 22 - 22 0
2.59.116.0 24 - 24 0
4.42.228.0 22 - 22 0
5.57.80.0 22 - 22 0
<snip>
2a13:df87:b400:: 38 - 38 0
2a13:df84:: 32 - 32 0
2630:: 16 - 16 0
Number of IPv4 Prefixes: 1166
Number of IPv6 Prefixes: 617
eva# show rpki prefix 2630::/16 0
Prefix Prefix Length Origin-AS
2630:: 16 - 16 0
eva#
Fixes: #15778
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Bing Shui [Wed, 17 Apr 2024 10:41:11 +0000 (10:41 +0000)]
ospfd: fix 'no write-multiplier' command
Signed-off-by: Bing Shui <652023330037@smail.nju.edu.cn>
Bing Shui [Wed, 17 Apr 2024 08:41:45 +0000 (08:41 +0000)]
ospfd: fix 'no maximum-paths' command
Signed-off-by: Bing Shui <652023330037@smail.nju.edu.cn>
Louis Scalbert [Wed, 17 Apr 2024 07:51:07 +0000 (09:51 +0200)]
bgpd: cleanup references to debug bgp allow-martians
The debug command was removed in
17e9298e47 ("bgpd: Remove 'debug bgp
allow-martian'")
Cleanup all references to the debug command.
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
Igor Ryzhov [Tue, 16 Apr 2024 20:34:20 +0000 (23:34 +0300)]
lib: fix keychain NB crash
Operational data should not be used on validation stage. Move the usage
to apply stage only.
Fixes #15707.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
Russ White [Tue, 16 Apr 2024 19:51:12 +0000 (15:51 -0400)]
Merge pull request #15715 from zhou-run/
202404092057
isisd: The hold time of hello packets on a P2P link does not match the sending interval.
Igor Ryzhov [Tue, 16 Apr 2024 19:10:45 +0000 (22:10 +0300)]
lib, zebra: fix exit commands
If a command is not marked as `YANG`-converted, the current command
batching buffer is flushed before executing the command. We shouldn't
flush the buffer when executing an `exit` command. It should only be
flushed if the next command is not `YANG`-converted, which is checked by
the command itself, not the previous `exit`.
Fixes #15706.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
Rajasekar Raja [Tue, 16 Apr 2024 18:33:08 +0000 (11:33 -0700)]
zebra: Actually display I/O buffer sizes (part-2)
An extension of commit-
8d8f12ba8e5cd11c189b8475b05539fa8415ccb9
Removing ifdef DEV_BUILD in stream_fifo_push as well to make the 'sh
zebra client' display the current I/O fifo along with max fifo items.
TICKET :#
3390099
Signed-off-by: Rajasekar Raja <rajasekarr@nvidia.com>
Mark Stapp [Tue, 16 Apr 2024 15:32:18 +0000 (11:32 -0400)]
Merge pull request #15709 from chiragshah6/fdev2
tools: frr-reload strip interface vrf ctx line
Philippe Guibert [Mon, 18 Sep 2023 09:24:42 +0000 (11:24 +0200)]
bgpd: add redistribute table-direct command for ipv6-unicast
The 'table-direct' redistribute command is available for ipv4 unicast but
not for ipv6 unicast.
Add the command to ipv6 unicast as well.
Fixes: b6367f8460 ("bgpd: add redistribute table-direct support")
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
Russ White [Tue, 16 Apr 2024 14:19:26 +0000 (10:19 -0400)]
Merge pull request #15755 from opensourcerouting/fix/check_for_bgpd_rpki
vtysh: Check if bgpd is enabled before installing vtysh commands for RPKI
Russ White [Tue, 16 Apr 2024 14:15:20 +0000 (10:15 -0400)]
Merge pull request #15733 from opensourcerouting/fix/json_output_for_show_bgp_ipv4_unicast_json_detail
bgpd: Drop newline in JSON output for `show bgp afi safi json detail`
Russ White [Tue, 16 Apr 2024 14:14:41 +0000 (10:14 -0400)]
Merge pull request #15732 from opensourcerouting/fix/drop_bgp_network_import_check_exact_cmd
bgpd: Drop `bgp_network_import_check_exact_cmd` command
Russ White [Tue, 16 Apr 2024 14:14:12 +0000 (10:14 -0400)]
Merge pull request #15726 from donaldsharp/med_value
bgpd: Fix display when using `missing-as-worst`
Russ White [Tue, 16 Apr 2024 11:55:05 +0000 (07:55 -0400)]
Merge pull request #15616 from pguibert6WIND/srv6_seg_list_sid_order
zebra: fix static srv6 segment-list sid order
Russ White [Tue, 16 Apr 2024 11:52:09 +0000 (07:52 -0400)]
Merge pull request #15572 from donaldsharp/best_path_stuff_sigh
bgp_process work
Martin Winter [Tue, 16 Apr 2024 11:40:52 +0000 (13:40 +0200)]
debian, redhat, snapcraft: Libyang min version is 2.1.128
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
Donatas Abraitis [Tue, 16 Apr 2024 08:56:39 +0000 (11:56 +0300)]
vtysh: Check if bgpd is enabled before installing vtysh commands for RPKI
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Donatas Abraitis [Tue, 16 Apr 2024 04:19:06 +0000 (07:19 +0300)]
Merge pull request #15749 from idryzhov/fix-dnssl
zebra: fix encoded DNSSL length
Igor Ryzhov [Mon, 15 Apr 2024 20:31:26 +0000 (23:31 +0300)]
zebra: fix encoded DNSSL length
The encoded DNSSL length is not set so the value is missing from RA
packet.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
Donald Sharp [Thu, 11 Apr 2024 14:46:46 +0000 (10:46 -0400)]
bgpd: Fix display when using `missing-as-worst`
The usage of the `bgp bestpath med missing-as-worst` command
was being accepted and applied during bestpath, but during output
of the routes affected by this it would not give any indication
that this was happening or what med value was being used.
Fixes: #15718
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Donald Sharp [Mon, 15 Apr 2024 15:29:04 +0000 (11:29 -0400)]
Merge pull request #15724 from opensourcerouting/fix/ospfd_cleanup_deprecation
ospfd, ospf6d: Remove deprecated JSON fields
Mark Stapp [Mon, 15 Apr 2024 15:26:54 +0000 (11:26 -0400)]
Merge pull request #15728 from raja-rajasekar/rajasekarr/backpressure_fix_coverity
zebra: backpressure - Fix Null ptr access (Coverity Issue)
Donald Sharp [Mon, 15 Apr 2024 15:24:05 +0000 (11:24 -0400)]
Merge pull request #15735 from opensourcerouting/feature/maximum-prefix_evpn
bgpd: Allow using maximum-prefix for EVPN
Donald Sharp [Mon, 15 Apr 2024 15:23:15 +0000 (11:23 -0400)]
Merge pull request #15734 from opensourcerouting/fix/compile_truncation
Fix compile warning with -Wformat-truncation